From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#66317: Project mode-line Date: Wed, 11 Oct 2023 09:27:50 +0300 Organization: LINKOV.NET Message-ID: <867cntd66x.fsf@mail.linkov.net> References: <86jzs4ntxb.fsf@mail.linkov.net> <86sf6r4omc.fsf@mail.linkov.net> <86jzs34mg6.fsf@mail.linkov.net> <83zg0z6062.fsf@gnu.org> <86il7mc3xr.fsf@mail.linkov.net> <867co29v1y.fsf@mail.linkov.net> <8634yjhbxq.fsf@mail.linkov.net> <86o7h7nex8.fsf@mail.linkov.net> <0d89af0c-070b-f681-7486-e923799c4c2e@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14683"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 66317@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 11 08:29:55 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qqSjD-0003fe-DC for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Oct 2023 08:29:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqSj1-0001Z7-Qb; Wed, 11 Oct 2023 02:29:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqSiz-0001YH-Ci for bug-gnu-emacs@gnu.org; Wed, 11 Oct 2023 02:29:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqSiz-0006O9-4r for bug-gnu-emacs@gnu.org; Wed, 11 Oct 2023 02:29:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qqSjK-0003UL-N7 for bug-gnu-emacs@gnu.org; Wed, 11 Oct 2023 02:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Oct 2023 06:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66317 X-GNU-PR-Package: emacs Original-Received: via spool by 66317-submit@debbugs.gnu.org id=B66317.169700577413340 (code B ref 66317); Wed, 11 Oct 2023 06:30:02 +0000 Original-Received: (at 66317) by debbugs.gnu.org; 11 Oct 2023 06:29:34 +0000 Original-Received: from localhost ([127.0.0.1]:37356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqSis-0003T6-4g for submit@debbugs.gnu.org; Wed, 11 Oct 2023 02:29:34 -0400 Original-Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]:53555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqSim-0003Sn-3t for 66317@debbugs.gnu.org; Wed, 11 Oct 2023 02:29:32 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 295C61BF203; Wed, 11 Oct 2023 06:28:57 +0000 (UTC) In-Reply-To: <0d89af0c-070b-f681-7486-e923799c4c2e@gutov.dev> (Dmitry Gutov's message of "Tue, 10 Oct 2023 14:46:49 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272244 Archived-At: >>>>>> Thanks, I've tried this patch on top of Emacs master and it seems to >>>>>> work well. One small suggestion is to consider giving the project name >>>>>> in the mode line a dedicated face, so people/themes could customize its >>>>>> appearance. (By default, it could just inherit from `default`.) >>>>> Thanks for suggestion, will do on the second round after pushing the >>>>> initial version. >>>> I'm not yet sure whether better to add a new face or a new variable like >>>> grep-hit-face and xref-num-matches-face that refers to the existing face. >>>> Then it would be possible to set such variable e.g. to the face `vc-state-base` >>>> that inherits from `default`. >>> Personally I think a variable pointing to a face name is a somewhat >>> redundant indirection, since customizing the face to inherit from some >>> other face is just as easy as customizing the variable to point to a >>> different face. But either way works, of course. >> Probably adding a variable would be more suitable since currently >> there are no faces defined in project.el at all. > > FWIW, I don't have a strong opinion. Ok, added a face variable.