From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#69305: outline-minor-mode for tabulated-list-mode Date: Thu, 22 Feb 2024 19:30:20 +0200 Organization: LINKOV.NET Message-ID: <867ciws983.fsf@mail.linkov.net> References: <86msrtvi06.fsf@mail.linkov.net> <86frxlmy1d.fsf@gnu.org> <86cyspt02f.fsf@mail.linkov.net> <861q94nc4j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28295"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 69305@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 22 18:49:53 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rdDCi-0007E6-BW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Feb 2024 18:49:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdDCX-0005xh-Fs; Thu, 22 Feb 2024 12:49:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdDCW-0005xT-GJ for bug-gnu-emacs@gnu.org; Thu, 22 Feb 2024 12:49:40 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdDCW-0007DL-7j for bug-gnu-emacs@gnu.org; Thu, 22 Feb 2024 12:49:40 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdDCt-0005Xo-5K for bug-gnu-emacs@gnu.org; Thu, 22 Feb 2024 12:50:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Feb 2024 17:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69305 X-GNU-PR-Package: emacs Original-Received: via spool by 69305-submit@debbugs.gnu.org id=B69305.170862414620945 (code B ref 69305); Thu, 22 Feb 2024 17:50:03 +0000 Original-Received: (at 69305) by debbugs.gnu.org; 22 Feb 2024 17:49:06 +0000 Original-Received: from localhost ([127.0.0.1]:45236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdDBw-0005Re-FR for submit@debbugs.gnu.org; Thu, 22 Feb 2024 12:49:06 -0500 Original-Received: from mslow1.mail.gandi.net ([217.70.178.240]:52993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdDBs-0005Qi-PZ for 69305@debbugs.gnu.org; Thu, 22 Feb 2024 12:49:03 -0500 Original-Received: from relay9-d.mail.gandi.net (unknown [IPv6:2001:4b98:dc4:8::229]) by mslow1.mail.gandi.net (Postfix) with ESMTP id C8656C3553 for <69305@debbugs.gnu.org>; Thu, 22 Feb 2024 17:41:54 +0000 (UTC) Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id CABB0FF803; Thu, 22 Feb 2024 17:41:33 +0000 (UTC) In-Reply-To: <861q94nc4j.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 22 Feb 2024 10:20:44 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280464 Archived-At: >> +@defvar tabulated-list-groups >> +This buffer-local variable specifies the groups of entries displayed in >> +the Tabulated List buffer. Its value should be either a list, or a >> +function. >> + >> +If the value is a list, each list element corresponds to one group, and >> +should have the form @w{@code{(@var{group-name} @var{entries})}}, where >> +@var{group-name} is a string inserted before all group entries, and >> +@var{entries} have the same format as @code{tabulated-list-entries} >> +(see above). >> + >> +Otherwise, the value should be a function which returns a list of the >> +above form when called with no arguments. >> +@end defvar > > I think the way to specify ENTRIES for this customization should be > described in more detail. Reading the above description, even the > idea of using ENTRIES for specifying grouping is unclear, since > tabulated-list-entries is basically just a list of column descriptors. But ENTRIES are described in 'tabulated-list-entries'. Here ENTRIES are no different from 'tabulated-list-entries' that are just column descriptors. >> +(defcustom Buffer-menu-group-by nil >> + "If non-nil, buffers are grouped by function. >> +This function takes one argument: a list of entries in the same format >> +as in `tabulated-list-entries', and should return a list in the format >> +suitable for `tabulated-list-groups'. Also when this variable is non-nil, >> +then `outline-minor-mode' is enabled in the Buffer Menu. Then with the >> +default value of `outline-regexp' you can use Outline minor mode commands >> +to show/hide groups of buffers. >> +The default options can group by a mode, and by a root directory of >> +a project or just `default-directory'." >> + :type '(choice (const :tag "No grouping" nil) >> + (function-item :tag "Group by mode" >> + Buffer-menu-group-by-mode) >> + (function-item :tag "Group by root" >> + Buffer-menu-group-by-root) > > I think the description text should be "Group by project" or "Group by > project root directory" or maybe "Group by project or directory". > Just "by root" is too vague. Ok, then will use "Group by project root or directory". >> +If `tabulated-list-groups' is non-nil, each group of entries >> +is sorted separately after printing the group header line. > > The part following "after printing" is IMO more confusing than > helpful. What will be lost if you remove it? Oops, this was too ugly, will remove this part. >> +(ert-deftest tabulated-list-groups () >> + (with-temp-buffer >> + (tabulated-list-mode) >> + (setq tabulated-list-groups >> + (reverse >> + (seq-group-by (lambda (b) (concat "* " (aref (cadr b) 3))) >> + tabulated-list--test-entries))) >> + (setq tabulated-list-format tabulated-list--test-format) >> + (setq tabulated-list-padding 7) >> + (tabulated-list-init-header) >> + (tabulated-list-print) > > This seems to test only the function value of tabulated-list-groups? > What about the other form of the value? The other forms have no functional difference.