From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69666: [PATCH] (vtable-update-object): Make old-object argument optional Date: Thu, 14 Mar 2024 11:00:51 +0200 Message-ID: <867ci5b324.fsf@gnu.org> References: <29c23366-b37c-422e-81f0-f0508e79460f@alphapapa.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26957"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69666@debbugs.gnu.org To: Adam Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 14 10:01:54 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rkgyG-0006Tw-Fz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Mar 2024 10:01:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkgxu-0007Jq-Nb; Thu, 14 Mar 2024 05:01:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkgxr-0007Iz-A1 for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2024 05:01:27 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rkgxr-0004OY-1Z for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2024 05:01:27 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rkgyQ-000135-7Z for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2024 05:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2024 09:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69666 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69666-submit@debbugs.gnu.org id=B69666.17104068973996 (code B ref 69666); Thu, 14 Mar 2024 09:02:02 +0000 Original-Received: (at 69666) by debbugs.gnu.org; 14 Mar 2024 09:01:37 +0000 Original-Received: from localhost ([127.0.0.1]:48316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkgy1-00012M-DN for submit@debbugs.gnu.org; Thu, 14 Mar 2024 05:01:37 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkgxz-000126-Ep for 69666@debbugs.gnu.org; Thu, 14 Mar 2024 05:01:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkgxK-00049l-7b; Thu, 14 Mar 2024 05:00:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bdH6tm5DckWHKlgxzdM/teOJkbJxo3NoSJW1OLXlt6c=; b=VoBW2Va/GSv7 BiUQF53+SsX6ZcISj/am56bNsM0qOflqVBEdZ8z+/oWWlCxOpmO7kgF7B3xRJsSJrg0LwmQ9pNoMm tGJtBENMVQ07B8kkKvAmFexQtgTJTVsnrG+nxAjMpM+oeWigVJ0xt4gv+gW1lkQkIEgHAtRMQrePW NvvbvwQVtqUBkuoPDiLN7338nWJ7YeIrR1xQmX5efS2+4owfDkO6A/EuZ3oNKm9pqMLQZx33eTPx/ 1T1d6IwoTwBPP8Beo7FtM6gnQV3iIGis3GgYIwwdUi4ngJkHIYuiVIOUSwvm3Ef9vU8AZzVELzerI ZGDORg9AqJ+5Rd9Lcq3WgA==; In-Reply-To: <29c23366-b37c-422e-81f0-f0508e79460f@alphapapa.net> (message from Adam Porter on Fri, 8 Mar 2024 23:51:33 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281598 Archived-At: > Date: Fri, 8 Mar 2024 23:51:33 -0600 > From: Adam Porter > > Please see the attached patch which makes `vtable-update-object' easier > to use in the common case of updating an existing object's > representation in a table (rather than replacing it with another object). Thanks, I have some minor comments below. > Subject: [PATCH] (vtable-update-object): Make old-object argument optional Since this changes the API of a public function, we need to call this out in NEWS. > +@defun vtable-update-object table object &optional old-object > +Change @var{old-object} into @var{object} in @var{table}; or, without > +@var{old-object}, update existing @var{object} in @var{table}. This > +also updates the displayed table. This is backwards: the documentation should first say what happens if the function is called with just 2 arguments, and then what happens if the 3rd one is supplied. Like this: Update @var{object} in @var{table} and redisplay @var{table}. Optional argument @var{old-object}, if non-@code{nil}, means to change @var{old-object} into @var{object}. > +(defun vtable-update-object (table object &optional old-object) > + "Replace OLD-OBJECT in TABLE with OBJECT. > +Without OLD-OBJECT, just update existing OBJECT in TABLE." Same here.