unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rudalics@gmx.at, 69983@debbugs.gnu.org
Subject: bug#69983: Use category for display-buffer-alist
Date: Tue, 09 Apr 2024 19:34:59 +0300	[thread overview]
Message-ID: <867ch7gfa4.fsf@mail.linkov.net> (raw)
In-Reply-To: <86v84rvwpa.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Apr 2024 10:09:37 +0300")

>> >>> One problem is that I can't find an alist item to limit
>> >>> the window height, i.e. can't find window-max-height
>> >>> that would be like window-min-height, but to set a max height.
>> >>> Could you suggest such an alist item?
>> >>
>> >> The intention was to have such behavior:
>> >> 1. after the first call that adds 1 line to the output buffer,
>> >>     resize the displayed buffer to 1 line height;
>> >> 2. after the second call grow the output window height to 2 lines,
>> >>     it seems fit-window-to-buffer should do this;
>> >> 3. after 10th call limit the window height to 10 lines only,
>> >>     so later calls should not increase the output window height
>> >>     more than 10 lines.
>> >
>> > You mean that when a 'window-height' action alist entry is provided that
>> > specifies 'fit-window-to-buffer' as 'window-height' value, we should
>> > pass it the value of any 'window-max-height' entry present as MAX-HEIGHT
>> > argument here
>> >
>> >          ((functionp height)
>> > 	  (ignore-errors (funcall height window))
>> >
>> > and probably do the same for all the other arguments of
>> > 'fit-window-to-buffer'?
>>
>> Probably we can't change the existing arguments to not break
>> backward-compatibility.  But this is fine since still can use
>> the explicit function call:
>>
>> diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el
>> index 8b43c6a8726..75b519067ac 100644
>> --- a/lisp/emacs-lisp/warnings.el
>> +++ b/lisp/emacs-lisp/warnings.el
>> @@ -362,7 +362,12 @@ display-warning
>
> Why does adding a new feature require changes in existing features,
> let alone such basic features as warnings.el?  Can't we introduce the
> category and leave warnings.el, flymake.el, and others alone?  I don't
> want to make unsolicited changes in those other places, because that
> runs the risk of disturbing people's arrangements of windows and their
> habits as to where the various windows pop up.

This is part of continuing development to improve
window handling for users of horizontally split windows.





  reply	other threads:[~2024-04-09 16:34 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-24 17:19 bug#69983: Use category for display-buffer-alist Juri Linkov
2024-03-25  9:41 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-25 17:12   ` Juri Linkov
2024-03-26  9:55     ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-27  7:15       ` Juri Linkov
2024-03-28  7:47         ` Juri Linkov
2024-03-28  8:23           ` Eli Zaretskii
2024-03-28 17:46             ` Juri Linkov
2024-03-28  9:18           ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28 17:50             ` Juri Linkov
2024-03-29  8:43               ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 16:30                 ` Juri Linkov
2024-03-30  9:36                   ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 18:22                     ` Juri Linkov
2024-04-02 16:52                       ` Juri Linkov
2024-04-04  6:16   ` Juri Linkov
2024-04-05 16:47     ` Juri Linkov
2024-04-06 18:42       ` Juri Linkov
2024-04-07  8:22         ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09  6:30           ` Juri Linkov
2024-04-09  7:09             ` Eli Zaretskii
2024-04-09 16:34               ` Juri Linkov [this message]
2024-04-09 18:28                 ` Eli Zaretskii
2024-04-10  6:45                   ` Juri Linkov
2024-04-10  8:47                     ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-10 11:07                     ` Eli Zaretskii
2024-04-10 17:49                       ` Juri Linkov
2024-04-10 18:13                         ` Eli Zaretskii
2024-04-11  6:31                           ` Juri Linkov
2024-04-11  7:40                             ` Eli Zaretskii
2024-04-12  6:37                               ` Juri Linkov
2024-04-12  7:05                                 ` Eli Zaretskii
2024-04-12 16:50                                   ` Juri Linkov
2024-04-12 18:27                                     ` Eli Zaretskii
2024-04-13 18:49                                       ` Juri Linkov
2024-04-13 19:03                                         ` Eli Zaretskii
2024-04-14 16:04                                           ` Juri Linkov
2024-04-18 14:30                                             ` Eli Zaretskii
2024-04-18 17:16                                               ` Juri Linkov
2024-04-18 17:56                                                 ` Eli Zaretskii
2024-04-19  6:24                                                   ` Juri Linkov
2024-04-19  6:28                                                     ` Juri Linkov
2024-04-19  7:19                                                       ` Eli Zaretskii
2024-04-19 16:17                                                       ` Juri Linkov
2024-04-20 12:08                                                         ` Eli Zaretskii
2024-04-21  6:52                                                           ` Juri Linkov
2024-04-21  9:13                                                             ` Eli Zaretskii
2024-04-22  6:50                                                               ` Juri Linkov
2024-04-19  7:19                                                     ` Eli Zaretskii
2024-04-11  9:16                       ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-11 11:03                         ` Eli Zaretskii
2024-04-24 16:46     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=867ch7gfa4.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=69983@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).