From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) Date: Sat, 13 Apr 2024 11:08:28 +0300 Message-ID: <867ch1r8g3.fsf@gnu.org> References: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> <878r1rgblr.fsf@betli.tmit.bme.hu> <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14845"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70193@debbugs.gnu.org To: martin rudalics , felician.nemeth@gmail.com, adonovan@google.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 13 10:09:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvYRa-0003bz-Tf for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Apr 2024 10:09:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvYRT-0007Ap-Cj; Sat, 13 Apr 2024 04:08:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvYRS-000794-CQ for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 04:08:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvYRQ-0008LX-El for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 04:08:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvYRa-0008Kr-M8 for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 04:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2024 08:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70193 X-GNU-PR-Package: emacs Original-Received: via spool by 70193-submit@debbugs.gnu.org id=B70193.171299573031954 (code B ref 70193); Sat, 13 Apr 2024 08:09:02 +0000 Original-Received: (at 70193) by debbugs.gnu.org; 13 Apr 2024 08:08:50 +0000 Original-Received: from localhost ([127.0.0.1]:60055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvYRO-0008JK-Fd for submit@debbugs.gnu.org; Sat, 13 Apr 2024 04:08:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvYRL-0008Ic-ML for 70193@debbugs.gnu.org; Sat, 13 Apr 2024 04:08:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvYR4-0008Fk-SP; Sat, 13 Apr 2024 04:08:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xmK795hWYQnlewZl26NxIUm/PpKdrkYfSoA8oEM6cRo=; b=bmcPz9AUIT4w ayYVX3f9vu7T2rA+jZqjESKj/7a7TMoAa17DFLQYwmDbkL9UnFCUzH+SunEon8V7Wyi3I5+2qfuMQ u5WQmr1/++MAFmGUvMgzyewNaAyUTIa4nUmj6kDDtFmtiIfMqhdb55MhZBO9PTC10P/7JWFZOo5yU e0/n5YsAN5l0tnhzggP/o25NOcOWAGKak2CTRvZUCkQzMFBqelW+2lsreZ54RRH1XNbPvXbquA00K p34fcSeLzY0EAAoxtcr9Sgh6ALcSsS9Aw90mFZfbfaciJbbvYoiVKYr2Nbs/HjTLgOHjU7HSgL6NQ BQQpW2MmRNY8sviu4gQSKw==; In-Reply-To: <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283187 Archived-At: > Cc: Alan Donovan , 70193@debbugs.gnu.org > Date: Sun, 7 Apr 2024 09:30:02 +0200 > From: martin rudalics via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > But when I debug window-recenter-region-start-position, the height is > > set to 0. The patch below seems to fix the problem. > [...] > > + (body-pixel-width (window-body-width window t)) > > + (body-pixel-height (window-body-height window t)) > > You're right. I meanwhile fixed the code to calculate how many lines to > step backwards by using 'window-text-pixel-size' there too. So now this > should work with text scaling and varying line heights too. > > If you want to test it with 'recenter-region', then a rough estimate is > that the number of lines shown after the first "L:" should be equal to > or one less than the number of lines shown after the third "L:" in each > message issued. I'm unsure how to proceed with this bug report. Should it be closed, or is there anything left to be done here, and if the latter, then what has to be done to resolve the issues? Thanks.