From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: 70311@debbugs.gnu.org, gregsexton@gmail.com
Subject: bug#70311: Crash when dnd-indicate-insertion-point is non-nil
Date: Sat, 13 Apr 2024 15:06:41 +0300 [thread overview]
Message-ID: <867ch1pium.fsf@gnu.org> (raw)
In-Reply-To: <87il0l325a.fsf@yahoo.com> (message from Po Lu on Sat, 13 Apr 2024 19:58:25 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: Greg Sexton <gregsexton@gmail.com>, 70311@debbugs.gnu.org
> Date: Sat, 13 Apr 2024 19:58:25 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Greg Sexton <gregsexton@gmail.com>
> >> Date: Tue, 9 Apr 2024 11:26:41 +0100
> >>
> >> Emacs (29.1.90) can crash on Mac OS X when dnd-indicate-insertion-point
> >> is non-nil.
> >>
> >> I'm not able to deterministically reproduce this, but I have a high
> >> success rate dragging a file over the window and just randomly moving
> >> it around without releasing the click.
> >>
> >> This said, I attached a debugger and found the root cause.
> >>
> >> There is code that looks like this in dnd-handle-movement:
> >>
> >> (when dnd-indicate-insertion-point
> >> (ignore-errors
> >> (goto-char (posn-point posn))))
> >>
> >> posn-point can return nil, which causes goto-char to call
> >> wrong_type_argument, this reaches signal_or_quit (eval.c), which calls
> >> emacs_abort as waiting_for_input is true.
> >>
> >> A quick fix might be to when-let the result of posn-point, but I'm
> >> unsure if waiting_for_input being true points to a deeper issue.
> >
> > Po Lu, any comments or suggestions?
>
> As regards suggestions, none at present. It's not clear to me why
> waiting_for_input should continue to exist, but neither am I especially
> satisfied with the present arrangements for calling drag-and-drop
> callbacks in nsterm.m: some means should be devised of returning to the
> event loop during a DND session, rather than calling Lisp and parts of
> redisplay from non-reentrant input handlers that the toolkit can call at
> will.
>
> Come to think of it, at the time this kludge was written, I never quite
> understood why DND events were never received on Mac OS, when the same
> was smooth sailing on GNUstep.
So you think the suggested bad-aid is the best we can currently do to
prevent crashes in those cases?
next prev parent reply other threads:[~2024-04-13 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 10:26 bug#70311: Crash when dnd-indicate-insertion-point is non-nil Greg Sexton
2024-04-13 9:20 ` Eli Zaretskii
2024-04-13 11:58 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-13 12:06 ` Eli Zaretskii [this message]
2024-04-13 12:28 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-13 16:00 ` Eli Zaretskii
2024-04-14 9:24 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-14 10:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867ch1pium.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70311@debbugs.gnu.org \
--cc=gregsexton@gmail.com \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).