From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body Date: Thu, 25 Apr 2024 19:04:14 +0300 Message-ID: <867cgl1la9.fsf@gnu.org> References: <87o7afod31.fsf@gmail.com> <87mspusb5k.fsf@thornhill.no> <87wmopaii8.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24573"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 70345-done@debbugs.gnu.org, theo@thornhill.no To: Jacob Leeming Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 25 18:06:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s01bv-0006CA-Qy for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Apr 2024 18:06:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s01bG-0005PA-85; Thu, 25 Apr 2024 12:05:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s01ab-00054n-QJ for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2024 12:04:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s01aZ-0005Ef-5x for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2024 12:04:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s01aq-0008SG-Q3 for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2024 12:05:04 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2024 16:05:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 70345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 70345@debbugs.gnu.org, eliz@gnu.org, jacobtophatleeming@gmail.com Original-Received: via spool by 70345-done@debbugs.gnu.org id=D70345.171406110232467 (code D ref 70345); Thu, 25 Apr 2024 16:05:04 +0000 Original-Received: (at 70345-done) by debbugs.gnu.org; 25 Apr 2024 16:05:02 +0000 Original-Received: from localhost ([127.0.0.1]:33151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s01aj-0008Qm-H4 for submit@debbugs.gnu.org; Thu, 25 Apr 2024 12:05:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s01ac-0008Nk-L5 for 70345-done@debbugs.gnu.org; Thu, 25 Apr 2024 12:04:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s01aF-00059l-3r; Thu, 25 Apr 2024 12:04:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ITrOKHNPSd63cWNSLMFJrpVyg/t0gFWlLXsg8vLQWag=; b=Yp+qerLaoPJU a3fE6S7OaZIARk1Unm9lZ/iAKOTnsR5igkVjOxOMw48YkOD+rOBaYhmo7jIgViM740AUCUgUSA7ch Tqc/uhb2LDTRI52vz8iCDNO/jbBn2BkbPZcMhpqV4bGI+h6iXDii4a93zbsxjFq7DHMaz7zXcvQG3 kjq3P+z0Cl1+GJ3NlOil0sq+98vTcmdjnade2zAKf/c4Gb8QSREkRYz0Od4y/YUO94Y2uPnXiKlPH 2nvzT5qKkXoQh3VujnoxeVJsw8wxRgmTR1zZomM5UoOikqVgVPaCrMDVz0n8xCFxgepJmdFVqVJQ4 2x6/ut3faHNVrBs1pBkZkA==; In-Reply-To: <87wmopaii8.fsf@gmail.com> (message from Jacob Leeming on Mon, 22 Apr 2024 09:50:23 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283950 Archived-At: > Cc: 70345@debbugs.gnu.org, Jacob Leeming > From: Jacob Leeming > Date: Mon, 22 Apr 2024 09:50:23 +0100 > > > Looks good to me. Are you willing to pack this up with a nice test > > confirming the behavior? > > > > All the best, > > Theo > > Thanks all, > > Discovered we had a similar issue for else blocks. Wrote a test that > covers both cases. > > See the attached diff which contains my changes to the indent rules and > the test. Thanks, I installed this on the emacs-29 branch. (The test you added should have been added to csharp-mode-tests.el, since our test files follow the names of the implementation files, and csharp-ts-mode is implemented in csharp-mode.el. I fixed that.) With this changeset you have exhausted the amount of changes that we can accept from you without copyright assignment. Would you like to start the paperwork of assigning the copyright at this time, so that we could accept your contributions in the future without limitations? If yes, I will send you the form to fill and the instructions to send the form. I'm closing this bug.