From: Eli Zaretskii <eliz@gnu.org>
To: Jacob Leeming <jacobtophatleeming@gmail.com>
Cc: dmitry@gutov.dev, 70345-done@debbugs.gnu.org, theo@thornhill.no
Subject: bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body
Date: Thu, 25 Apr 2024 19:04:14 +0300 [thread overview]
Message-ID: <867cgl1la9.fsf@gnu.org> (raw)
In-Reply-To: <87wmopaii8.fsf@gmail.com> (message from Jacob Leeming on Mon, 22 Apr 2024 09:50:23 +0100)
> Cc: 70345@debbugs.gnu.org, Jacob Leeming <jacobtophatleeming@gmail.com>
> From: Jacob Leeming <jacobtophatleeming@gmail.com>
> Date: Mon, 22 Apr 2024 09:50:23 +0100
>
> > Looks good to me. Are you willing to pack this up with a nice test
> > confirming the behavior?
> >
> > All the best,
> > Theo
>
> Thanks all,
>
> Discovered we had a similar issue for else blocks. Wrote a test that
> covers both cases.
>
> See the attached diff which contains my changes to the indent rules and
> the test.
Thanks, I installed this on the emacs-29 branch. (The test you added
should have been added to csharp-mode-tests.el, since our test files
follow the names of the implementation files, and csharp-ts-mode is
implemented in csharp-mode.el. I fixed that.)
With this changeset you have exhausted the amount of changes that we
can accept from you without copyright assignment. Would you like to
start the paperwork of assigning the copyright at this time, so that
we could accept your contributions in the future without limitations?
If yes, I will send you the form to fill and the instructions to send
the form.
I'm closing this bug.
next prev parent reply other threads:[~2024-04-25 16:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 20:32 bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body Jacob Leeming
2024-04-12 5:45 ` Eli Zaretskii
2024-04-14 23:02 ` Yuan Fu
2024-04-15 4:56 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 19:01 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 21:38 ` Jacob Leeming
2024-04-16 0:27 ` Dmitry Gutov
2024-04-22 8:50 ` Jacob Leeming
2024-04-25 16:04 ` Eli Zaretskii [this message]
2024-04-26 13:53 ` Jacob Leeming
2024-04-26 15:24 ` Eli Zaretskii
2024-04-27 13:10 ` john muhl
2024-04-27 15:41 ` Eli Zaretskii
2024-04-27 17:13 ` john muhl
2024-04-27 19:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867cgl1la9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70345-done@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=jacobtophatleeming@gmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).