* bug#70578: [PATCH] ; Fix python test case for testing completion with ipython
@ 2024-04-26 3:27 Lin Sun
2024-04-27 9:53 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Lin Sun @ 2024-04-26 3:27 UTC (permalink / raw)
To: 70578
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
Hi,
There is an error when running python-tests.el, I pasted on the tail
of this mail.
The error is caused by the test case trying testing the functions with
ipython but its subroutine didn't use the ipython as interpreter.
Changing the test interpreter will fix the issue, I attached the patch.
Please help apply the change. Thanks.
Test case error message:
Test python-shell-completion-at-point-ipython backtrace:
call-process("python" nil t nil "-m" "jedi" "repl")
(eql 0 (call-process python-tests-shell-interpreter nil t nil "-m" "
(if (eql 0 (call-process python-tests-shell-interpreter nil t nil "-
...
Test python-shell-completion-at-point-ipython condition:
(file-missing "Searching for program" "No such file or directory"
"python")
FAILED 1/1 python-shell-completion-at-point-ipython (0.829918
sec) at python-tests.el:4897
[-- Attachment #2: 0001-Fix-python-test-case-for-testing-completion-with-ipy.patch --]
[-- Type: text/x-patch, Size: 1105 bytes --]
From ca8d5fb6c8d8591c20ec99e00e7e63fd2c9d1151 Mon Sep 17 00:00:00 2001
From: Lin Sun <sunlin7@hotmail.com>
Date: Thu, 25 Apr 2024 06:54:27 +0000
Subject: [PATCH] ; Fix python test case for testing completion with ipython
* test/lisp/progmodes/python-tests.el
(python-shell-completion-at-point-ipython): Fix the python interpreter
is incorrect in the subroutine.
---
test/lisp/progmodes/python-tests.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el
index e11440cdb5b..e6e6e05bbef 100644
--- a/test/lisp/progmodes/python-tests.el
+++ b/test/lisp/progmodes/python-tests.el
@@ -4896,7 +4896,8 @@ python-shell-completion-at-point-jedi-completer
(ert-deftest python-shell-completion-at-point-ipython ()
"Check if Python shell completion works for IPython."
- (let ((python-shell-interpreter "ipython")
+ (let ((python-tests-shell-interpreter "ipython")
+ (python-shell-interpreter "ipython")
(python-shell-interpreter-args "-i --simple-prompt"))
(skip-unless
(and
--
2.20.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#70578: [PATCH] ; Fix python test case for testing completion with ipython
2024-04-26 3:27 bug#70578: [PATCH] ; Fix python test case for testing completion with ipython Lin Sun
@ 2024-04-27 9:53 ` Eli Zaretskii
2024-04-27 12:09 ` kobarity
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2024-04-27 9:53 UTC (permalink / raw)
To: Lin Sun, kobarity; +Cc: 70578
> From: Lin Sun <sunlin7.mail@gmail.com>
> Date: Fri, 26 Apr 2024 03:27:34 +0000
>
> There is an error when running python-tests.el, I pasted on the tail
> of this mail.
>
> The error is caused by the test case trying testing the functions with
> ipython but its subroutine didn't use the ipython as interpreter.
>
> Changing the test interpreter will fix the issue, I attached the patch.
>
> Please help apply the change. Thanks.
>
>
> Test case error message:
>
> Test python-shell-completion-at-point-ipython backtrace:
> call-process("python" nil t nil "-m" "jedi" "repl")
> (eql 0 (call-process python-tests-shell-interpreter nil t nil "-m" "
> (if (eql 0 (call-process python-tests-shell-interpreter nil t nil "-
> ...
> Test python-shell-completion-at-point-ipython condition:
> (file-missing "Searching for program" "No such file or directory"
> "python")
> FAILED 1/1 python-shell-completion-at-point-ipython (0.829918
> sec) at python-tests.el:4897
Thanks.
kobarity, any comments about this or the patch?
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#70578: [PATCH] ; Fix python test case for testing completion with ipython
2024-04-27 9:53 ` Eli Zaretskii
@ 2024-04-27 12:09 ` kobarity
2024-04-29 15:36 ` Lin Sun
0 siblings, 1 reply; 5+ messages in thread
From: kobarity @ 2024-04-27 12:09 UTC (permalink / raw)
To: Lin Sun, Eli Zaretskii; +Cc: Liu Hui, 70578
Eli Zaretskii wrote:
>
> > From: Lin Sun <sunlin7.mail@gmail.com>
> > Date: Fri, 26 Apr 2024 03:27:34 +0000
> >
> > There is an error when running python-tests.el, I pasted on the tail
> > of this mail.
> >
> > The error is caused by the test case trying testing the functions with
> > ipython but its subroutine didn't use the ipython as interpreter.
> >
> > Changing the test interpreter will fix the issue, I attached the patch.
> >
> > Please help apply the change. Thanks.
> >
> >
> > Test case error message:
> >
> > Test python-shell-completion-at-point-ipython backtrace:
> > call-process("python" nil t nil "-m" "jedi" "repl")
> > (eql 0 (call-process python-tests-shell-interpreter nil t nil "-m" "
> > (if (eql 0 (call-process python-tests-shell-interpreter nil t nil "-
> > ...
> > Test python-shell-completion-at-point-ipython condition:
> > (file-missing "Searching for program" "No such file or directory"
> > "python")
> > FAILED 1/1 python-shell-completion-at-point-ipython (0.829918
> > sec) at python-tests.el:4897
>
> Thanks.
>
> kobarity, any comments about this or the patch?
I confirmed that Lin Sun's patch fixes this issue. I Cc'd the author
of this ERT as well, just in case.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#70578: [PATCH] ; Fix python test case for testing completion with ipython
2024-04-27 12:09 ` kobarity
@ 2024-04-29 15:36 ` Lin Sun
2024-05-02 9:06 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Lin Sun @ 2024-04-29 15:36 UTC (permalink / raw)
To: kobarity; +Cc: Liu Hui, Eli Zaretskii, 70578
On Sat, Apr 27, 2024 at 12:10 PM kobarity <kobarity@gmail.com> wrote:
>
>
> Eli Zaretskii wrote:
> >
> > > From: Lin Sun <sunlin7.mail@gmail.com>
> > > Date: Fri, 26 Apr 2024 03:27:34 +0000
> > >
> > > There is an error when running python-tests.el, I pasted on the tail
> > > of this mail.
> > >
> > > The error is caused by the test case trying testing the functions with
> > > ipython but its subroutine didn't use the ipython as interpreter.
> > >
> > > Changing the test interpreter will fix the issue, I attached the patch.
> > >
> > > Please help apply the change. Thanks.
> > >
> > >
> > > Test case error message:
> > >
> > > Test python-shell-completion-at-point-ipython backtrace:
> > > call-process("python" nil t nil "-m" "jedi" "repl")
> > > (eql 0 (call-process python-tests-shell-interpreter nil t nil "-m" "
> > > (if (eql 0 (call-process python-tests-shell-interpreter nil t nil "-
> > > ...
> > > Test python-shell-completion-at-point-ipython condition:
> > > (file-missing "Searching for program" "No such file or directory"
> > > "python")
> > > FAILED 1/1 python-shell-completion-at-point-ipython (0.829918
> > > sec) at python-tests.el:4897
> >
> > Thanks.
> >
> > kobarity, any comments about this or the patch?
>
> I confirmed that Lin Sun's patch fixes this issue. I Cc'd the author
> of this ERT as well, just in case.
Thanks for confirmation, look forward to the merging happening.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#70578: [PATCH] ; Fix python test case for testing completion with ipython
2024-04-29 15:36 ` Lin Sun
@ 2024-05-02 9:06 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2024-05-02 9:06 UTC (permalink / raw)
To: Lin Sun; +Cc: liuhui1610, kobarity, 70578-done
> From: Lin Sun <sunlin7.mail@gmail.com>
> Date: Mon, 29 Apr 2024 15:36:16 +0000
> Cc: Eli Zaretskii <eliz@gnu.org>, Liu Hui <liuhui1610@gmail.com>, 70578@debbugs.gnu.org
>
> On Sat, Apr 27, 2024 at 12:10 PM kobarity <kobarity@gmail.com> wrote:
> >
> >
> > I confirmed that Lin Sun's patch fixes this issue. I Cc'd the author
> > of this ERT as well, just in case.
>
> Thanks for confirmation, look forward to the merging happening.
Now installed on master, and closing the bug.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-02 9:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-26 3:27 bug#70578: [PATCH] ; Fix python test case for testing completion with ipython Lin Sun
2024-04-27 9:53 ` Eli Zaretskii
2024-04-27 12:09 ` kobarity
2024-04-29 15:36 ` Lin Sun
2024-05-02 9:06 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).