unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>,
	justin@burkett.cc, Jeremy Bryant <jb@jeremybryant.net>
Cc: 71648@debbugs.gnu.org
Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings
Date: Wed, 19 Jun 2024 16:12:05 +0300	[thread overview]
Message-ID: <867celoz4q.fsf@gnu.org> (raw)
In-Reply-To: <87plsdxhnw.fsf@gmail.com> (message from Robert Pluim on Wed, 19 Jun 2024 14:04:35 +0200)

> From: Robert Pluim <rpluim@gmail.com>
> Date: Wed, 19 Jun 2024 14:04:35 +0200
> 
> `which-key-mode' currently only looks at keymaps, not translation
> keymaps such as `key-translation-map' and `function-key-map'. In order
> to aid discoverability, perhaps it should do the following
> 
> (maybe with a user option)
> 
> @@ -1942,8 +1949,10 @@ which-key--get-keymap-bindings
>  
>  (defun which-key--get-current-bindings (&optional prefix filter)
>    "Generate a list of current active bindings."
> -  (let (bindings)
> -    (dolist (map (current-active-maps t) bindings)
> +  (let (bindings
> +        (maps (nconc (current-active-maps t)
> +                     (list key-translation-map function-key-map))))
> +    (dolist (map maps bindings)
>        (when (cdr map)
>          (setq bindings
>                (which-key--get-keymap-bindings
> 

Let's have the relevant people on-board of this discussion.





  reply	other threads:[~2024-06-19 13:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19 12:04 bug#71648: 30.0.50; Allow which-key to report on translation bindings Robert Pluim
2024-06-19 13:12 ` Eli Zaretskii [this message]
2024-06-19 15:09   ` Justin Burkett
2024-06-19 15:16     ` Robert Pluim
2024-06-19 15:42       ` Justin Burkett
2024-06-19 21:13       ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-19 15:34     ` Eli Zaretskii
2024-06-19 15:48       ` Justin Burkett
2024-06-20  8:27         ` Robert Pluim
2024-06-20 14:20           ` Justin Burkett
2024-06-20 14:56             ` Robert Pluim
2024-06-20 15:40               ` Justin Burkett
2024-06-24 13:14                 ` Robert Pluim
2024-06-24 13:30                   ` Eli Zaretskii
2024-06-24 17:20                     ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=867celoz4q.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=71648@debbugs.gnu.org \
    --cc=jb@jeremybryant.net \
    --cc=justin@burkett.cc \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).