From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Date: Sat, 20 Jul 2024 12:42:00 +0300 Message-ID: <867cdge6xj.fsf@gnu.org> References: <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@gutov.dev> <8634pewsej.fsf@gnu.org> <8634oy7s3s.fsf@gnu.org> <86a5iv55ej.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27031"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71209@debbugs.gnu.org, dmitry@gutov.dev, dev@rjt.dev To: noah.v.peart@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 20 11:43:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sV6ch-0006rk-N8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Jul 2024 11:43:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sV6cJ-00025T-7E; Sat, 20 Jul 2024 05:43:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sV6cI-00025C-Hy for bug-gnu-emacs@gnu.org; Sat, 20 Jul 2024 05:43:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sV6cI-0001fh-1X for bug-gnu-emacs@gnu.org; Sat, 20 Jul 2024 05:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sV6cI-0007yt-3L for bug-gnu-emacs@gnu.org; Sat, 20 Jul 2024 05:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Jul 2024 09:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71209 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71209-submit@debbugs.gnu.org id=B71209.172146853230597 (code B ref 71209); Sat, 20 Jul 2024 09:43:02 +0000 Original-Received: (at 71209) by debbugs.gnu.org; 20 Jul 2024 09:42:12 +0000 Original-Received: from localhost ([127.0.0.1]:51737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sV6bU-0007xQ-8G for submit@debbugs.gnu.org; Sat, 20 Jul 2024 05:42:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sV6bR-0007xB-Mk for 71209@debbugs.gnu.org; Sat, 20 Jul 2024 05:42:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sV6bM-0001al-0g; Sat, 20 Jul 2024 05:42:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2en4q05iKy0aFnzZbEuhtPkXxc30UXy58409k+Mj9BY=; b=d+kQsOGG+3joUNL4IwoZ MDp8M2fn48LEWIBtZdBmOZ6La/PomT53d3Cjecx7//yKRn8gB5UV2nViaXFPLDj8mECMI78kTWvzn RgXFYYg7/CVgvIjrqDUHmT1wuufj16oWuDOP+qe4ml6QbM9IBbXJ8bWxADphQuZl1ghKgA6VUHNxO yagqaEUeQjGmCXeQNi82bkhgQQC9hb3nt68et77+gc3aqP2vrwQX0uUPOQGZ4E1b9sexrD5ToIl9e IwYiUOBo9ZRhqT+79xDJlh3ChQByQAJoEJKwLCsfvUPAn2yn7v6YOW7SrKGeExmxPcVz+c3R3P/ER BXpX8rafGQZI5Q==; In-Reply-To: <86a5iv55ej.fsf@gnu.org> (message from Eli Zaretskii on Sat, 06 Jul 2024 10:46:44 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289024 Archived-At: Ping! Ping! Can we please make some progress here? > Cc: 71209@debbugs.gnu.org, dmitry@gutov.dev, dev@rjt.dev > Date: Sat, 06 Jul 2024 10:46:44 +0300 > From: Eli Zaretskii > > Ping! Any progress with this? > > > From: Noah Peart > > Date: Thu, 27 Jun 2024 05:29:21 -0400 > > Cc: dmitry@gutov.dev, 71209@debbugs.gnu.org, dev@rjt.dev > > > > Ah yes, sorry to be slow, I can submit a patch for those settings. I'll take a look today! > > > > On Thu, Jun 27, 2024 at 3:38 AM Eli Zaretskii wrote: > > > > Ping! Ping! Noah, are you still interested in working on this? > > > > > Cc: 71209@debbugs.gnu.org, dev@rjt.dev > > > Date: Sat, 15 Jun 2024 10:56:36 +0300 > > > From: Eli Zaretskii > > > > > > Ping! Noah, would you please answer Dmitry? > > > > > > > Cc: 71209@debbugs.gnu.org > > > > Date: Sat, 1 Jun 2024 17:13:57 +0300 > > > > From: Dmitry Gutov > > > > > > > > On 01/06/2024 04:42, Noah Peart wrote: > > > > > > > > > > I've been using these for c++, I think they are still missing > > > > > > > > > > ;; for (auto x: ...) > > > > > (for_range_loop > > > > > declarator: (identifier) @font-lock-variable-name-face) > > > > > ;; auto& x > > > > > (reference_declarator > > > > > (identifier) @font-lock-variable-name-face) > > > > > ;; auto[&] [x, y] > > > > > (structured_binding_declarator > > > > > _ [(identifier)] @font-lock-variable-name-face) > > > > > > > > > > I suppose most people keep the default font-locking for variable-name > > > > > and variable-use, so these missing rules go unnoticed. > > > > > > > > Do you want to submit a full patch with these as well? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >