From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72138: 30.0.50; [PATCH] Fix ring size in comint-read-input-ring Date: Sat, 27 Jul 2024 10:13:52 +0300 Message-ID: <867cd72tov.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29925"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72138-done@debbugs.gnu.org To: Liu Hui Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 27 09:15:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sXbeD-0007er-6X for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Jul 2024 09:15:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sXbdn-0003zQ-LQ; Sat, 27 Jul 2024 03:14:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sXbdm-0003tZ-5D for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2024 03:14:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sXbdl-0000P3-SW for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2024 03:14:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sXbdv-0002g5-GZ for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2024 03:15:03 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jul 2024 07:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 72138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 72138@debbugs.gnu.org, eliz@gnu.org, liuhui1610@gmail.com Original-Received: via spool by 72138-done@debbugs.gnu.org id=D72138.172206445310052 (code D ref 72138); Sat, 27 Jul 2024 07:15:03 +0000 Original-Received: (at 72138-done) by debbugs.gnu.org; 27 Jul 2024 07:14:13 +0000 Original-Received: from localhost ([127.0.0.1]:40429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXbd7-0002bk-2d for submit@debbugs.gnu.org; Sat, 27 Jul 2024 03:14:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXbd4-0002Zt-Ej for 72138-done@debbugs.gnu.org; Sat, 27 Jul 2024 03:14:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sXbcp-0000Fs-2r; Sat, 27 Jul 2024 03:13:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=q2WIJXKeXLAR61l8lLjCkwf8IZjtP1oLxzDo/5uB5HU=; b=n+M8MjRA/c6/ 5aF+FpGcrq0oxodUk3hO3y+ym572h602CIZUj7igRSzCYF+9cnke0mJm733aY+K/1qBaZlCQaX7R+ dI+hmcflNFREj0ujWya9M2D34Gy/RcvjsyhfmaIM4rKMz/AeTZJuI7zTf+Ullv7VHDkYUWK9FlzVz qG1ouz673tQCc1NtOvvw4JLPB9HNX3mCJ5QbS3zst8Z4l8qnsWnAaC3mLOckQMYaAqVxdabmsJz/h xtTQL9zrj2BPQ/XAR74VoZdLjS83dDkepTFdowxJyvZ0q1LitN04984tZUE6CeXrbCPQ70nnFOPtK l4N7vi5n3v+v8DJ8hiWdbw==; In-Reply-To: (message from Liu Hui on Tue, 16 Jul 2024 18:10:00 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289409 Archived-At: > From: Liu Hui > Date: Tue, 16 Jul 2024 18:10:00 +0800 > > When comint-read-input-ring reads history to the ring, the global > value of comint-input-ring-size (i.e. 500) is used regardless of the > local value due to the use of temp buffer. For example: > > 1. HISTSIZE=10 emacs -Q > 2. M-x shell > > The buffer-local value of comint-input-ring-size is correctly set to > 10, but C-c C-l shows 500 commands. > > The attached patch fixes the problem that comint-read-input-ring > ignores the buffer-local comint-input-ring-size. Thanks. Thanks, installed on the master branch, and closing the bug.