From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 72485@debbugs.gnu.org
Subject: bug#72485: Support 'visual-wrap-prefix-mode' in SHR/EWW
Date: Sat, 17 Aug 2024 11:55:57 +0300 [thread overview]
Message-ID: <867ccf4jfm.fsf@gnu.org> (raw)
In-Reply-To: <ae976439-2100-7653-958c-65fb9ea84b52@gmail.com> (message from Jim Porter on Mon, 5 Aug 2024 20:47:52 -0700)
> Date: Mon, 5 Aug 2024 20:47:52 -0700
> From: Jim Porter <jporterbugs@gmail.com>
>
> This patch is an extension of bug#71605, and the first place to
> explicitly use the new variable-pitch support for
> 'visual-wrap-prefix-mode'. While implementing this, I found two small
> bugs in the new 'visual-wrap-prefix-mode' code:
>
> 1. When setting the min-width for the first line prefix, we should use
> 'add-display-text-property' so as not to clobber other display properties.
>
> 2. My attempts to be "helpful" by special-casing wrap-prefixes of all
> spaces ended up just interfering with more complex cases (like SHR), so
> I removed it. The code is now simpler (one fewer condition) and just
> works more smoothly overall.
>
> There's one limitation to this patch though: since SHR uses absolute
> pixel-widths for indenting internally, things can look mis-indented if
> you scale the text in the buffer. However, SHR has exactly the same
> issue when *not* using 'visual-wrap-prefix-mode', so it's really just a
> more-general bug in SHR. (It'd be nice to fix that, but I'd have to get
> a better understanding of how indentation and <table> elements interact.)
Thanks. This lacks a NEWS entry, but other than that, feel fee to
install on master when ready.
next prev parent reply other threads:[~2024-08-17 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 3:47 bug#72485: Support 'visual-wrap-prefix-mode' in SHR/EWW Jim Porter
2024-08-17 8:55 ` Eli Zaretskii [this message]
2024-08-18 0:30 ` Jim Porter
2024-08-18 4:49 ` Eli Zaretskii
2024-08-18 6:13 ` Jim Porter
2024-08-18 9:20 ` Eli Zaretskii
2024-08-18 16:58 ` Jim Porter
2024-08-18 18:12 ` Eli Zaretskii
2024-08-18 18:28 ` Jim Porter
2024-08-18 18:53 ` Eli Zaretskii
2024-08-18 23:10 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867ccf4jfm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72485@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).