From: Eli Zaretskii <eliz@gnu.org>
To: pipcet@protonmail.com
Cc: execvy@gmail.com, 72692-done@debbugs.gnu.org
Subject: bug#72692: Emacs 31.05 (40eecd594ac) get SIGSEGV on Linux (Linux 6.6.45 Kde Wayland)
Date: Sat, 24 Aug 2024 12:09:09 +0300 [thread overview]
Message-ID: <867cc6nv7u.fsf@gnu.org> (raw)
In-Reply-To: <86wmkcwj9c.fsf@gnu.org> (message from Eli Zaretskii on Mon, 19 Aug 2024 19:49:03 +0300)
> Cc: execvy@gmail.com, 72692@debbugs.gnu.org
> Date: Mon, 19 Aug 2024 19:49:03 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > Date: Mon, 19 Aug 2024 16:34:59 +0000
> > From: Pip Cet <pipcet@protonmail.com>
> > Cc: execvy@gmail.com, 72692@debbugs.gnu.org
> >
> > "Eli Zaretskii" <eliz@gnu.org> writes:
> >
> > > Thanks, but I'd also like to see the callers which call
> > > free_realized_face in a way that causes the latter to call
> > > free_face_fontset. That's why I asked for backtraces from those
> > > calls, but I don't think you sent such backtraces. What you sent was
> >
> > Just for the record, you asked:
> >
> > > So can you show a backtrace from the call to free_realized_faces
> > > (supposedly called by realize_basic_faces?) which causes these
> > > printfs:
> > > > fontset 103 used for face 0x117cca0
> > > > fontset 103 used for face 0x2a7a3c0
> > > > fontset 103 used for face 0x117cca0
> > > > fontset 103 used for face 0x2a62860
> >
> > ... which I misunderstood. Sorry.
>
> Sorry for being unclear.
>
> > Is this what you want?
>
> Yes, recompute_basic_faces was the prime suspect. I think we added
> several calls to it over the last years, to fix problems with face
> cache being emptied at some unexpected times.
>
> > Indeed, I can report that the bug doesn't seem to occur after this
> > simple change:
> >
> > diff --git a/src/xfaces.c b/src/xfaces.c
> > index 684b6ccfac7..a4ac9c0787a 100644
> > --- a/src/xfaces.c
> > +++ b/src/xfaces.c
> > @@ -736,6 +736,7 @@ recompute_basic_faces (struct frame *f)
> > clear_face_cache (false);
> > if (!realize_basic_faces (f))
> > emacs_abort ();
> > + f->face_change = true;
> > }
> > }
> >
> >
> > So something like that (though moving the call down into
> > realize_basic_faces or even further would be good) would probably work
> > for the OP, and emacs-30?
>
> I think setting the flag in recompute_basic_faces should be enough.
> Let me think about it some more.
I decided to go with this change only, and installed it on the
emacs-30 release branch. Let's hope it makes this tricky problem go
away.
I'm closing this bug. If the problem resurfaces, we can reopen it.
next prev parent reply other threads:[~2024-08-24 9:09 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-18 8:29 bug#72692: Emacs 31.05 (40eecd594ac) get SIGSEGV on Linux (Linux 6.6.45 Kde Wayland) Eval EXEC
2024-08-18 8:58 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-18 9:08 ` Eval EXEC
2024-08-18 9:23 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-18 9:24 ` execvy
2024-08-18 9:34 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-18 9:36 ` execvy
2024-08-18 12:43 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-18 12:53 ` execvy
2024-08-18 13:35 ` Eli Zaretskii
2024-08-18 13:44 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-18 14:12 ` Eli Zaretskii
2024-08-18 14:59 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-18 15:38 ` Eli Zaretskii
2024-08-18 16:08 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-18 17:55 ` Eli Zaretskii
2024-08-18 18:11 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-18 18:52 ` Eli Zaretskii
2024-08-19 6:17 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-18 17:56 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-18 18:38 ` Eli Zaretskii
2024-08-19 6:28 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-19 11:30 ` Eli Zaretskii
2024-08-19 13:32 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-19 14:35 ` Eli Zaretskii
2024-08-19 15:03 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-19 15:54 ` Eli Zaretskii
2024-08-19 16:34 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-19 16:49 ` Eli Zaretskii
2024-08-24 9:09 ` Eli Zaretskii [this message]
2024-08-24 10:04 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-24 10:13 ` Eli Zaretskii
2024-08-25 17:58 ` Juri Linkov
2024-08-25 18:49 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-27 16:31 ` Juri Linkov
2024-08-28 11:50 ` Eli Zaretskii
2024-08-28 16:21 ` Juri Linkov
2024-08-28 17:53 ` Eli Zaretskii
2024-08-28 18:35 ` Juri Linkov
2024-08-28 18:57 ` Eli Zaretskii
2024-08-28 19:02 ` Juri Linkov
2024-08-29 4:36 ` Eli Zaretskii
2024-08-29 10:06 ` Eli Zaretskii
2024-08-29 12:06 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-29 12:26 ` Eli Zaretskii
2024-09-07 7:52 ` Eli Zaretskii
2024-09-08 0:42 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-28 17:56 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-25 18:57 ` Eli Zaretskii
2024-08-26 5:52 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-26 12:39 ` Eli Zaretskii
2024-08-26 19:04 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-26 19:20 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-27 11:47 ` Eli Zaretskii
2024-08-27 19:26 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-28 11:48 ` Eli Zaretskii
2024-08-28 11:58 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-27 11:44 ` Eli Zaretskii
2024-08-27 19:23 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-28 11:41 ` Eli Zaretskii
2024-08-28 12:07 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-28 12:51 ` Eli Zaretskii
2024-08-18 19:24 ` Eli Zaretskii
2024-08-19 6:07 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-19 14:17 ` Eli Zaretskii
2024-08-19 14:44 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867cc6nv7u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72692-done@debbugs.gnu.org \
--cc=execvy@gmail.com \
--cc=pipcet@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).