From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64055: Implementation of modifying VC change comments for Git Date: Sun, 20 Oct 2024 11:32:50 +0300 Message-ID: <867ca3jhsd.fsf@gnu.org> References: <874j59wym3.fsf@melete.silentflame.com> <868qukl73k.fsf@gnu.org> <87bjzfuzaq.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22913"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Morgan.J.Smith@outlook.com, 64055@debbugs.gnu.org, dgutov@yandex.ru To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 20 10:34:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2RNz-0005po-Dz for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Oct 2024 10:34:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2RNc-0002i9-V9; Sun, 20 Oct 2024 04:33:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2RNa-0002ho-0u for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 04:33:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2RNZ-00089U-Bc for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 04:33:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=rQi756t0Px2WypiAErnTgT5VqukMDy6MW21cjZ0u0qY=; b=CWktDnsVFsyxipINGc/mFd/41kSkTOodLVflkHvhD7YY+o9mJGGvyRbnong4ZqsJQIg8dx9fGbs1CB6cEpelEWzgCdxOYLuoKPHzUtNPwVI+aSfWsgKRBX1H3hTACGxxZi5pa73BK41Hh4ffUHa0Fbr9PYagNy4iOg6qBrm7LNk8UJM7LWsqvkKxcOHXOEkfKHjOIPpYHQNwIWUBMAZtohkpMUqXogavtmXx2tG8ShnFwxtK7+PM9C0tORAOiBphI8hDi/E2xxLLaH+fr09z0zFtZPGXm0FZBuNWFyc8EoXe+u77fvxTVW/oO1xGLR4bgA4EFW71MFlXE8NHmgYbow==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2RNy-0002QY-4y for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 04:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2024 08:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.17294132069287 (code B ref 64055); Sun, 20 Oct 2024 08:34:02 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 20 Oct 2024 08:33:26 +0000 Original-Received: from localhost ([127.0.0.1]:45692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2RNO-0002Pj-7c for submit@debbugs.gnu.org; Sun, 20 Oct 2024 04:33:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2RNM-0002PT-HS for 64055@debbugs.gnu.org; Sun, 20 Oct 2024 04:33:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2RMr-00086J-Gf; Sun, 20 Oct 2024 04:32:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rQi756t0Px2WypiAErnTgT5VqukMDy6MW21cjZ0u0qY=; b=VMU/D3k0oxAC RBbanYpicRDoFv5XOc8Zoa7W53nrmotIxbi/uyuZOL2Ar/ybN1oHi4zoi3m7BQU5/DkJMoSE6YjID aM4gU6WQ9D0JaJHaOKZRpf8tOXGTs3KoGFM6XZr6M3c2rYgaHf78pyHU/YcR/ly3hVIqW5WUNaz0E yOlVvIuMRngHyPmVhVopWt8YgLigxD0u2U0UIqgsDa/cdBHlLZY9OgrMTR2lGu/wbkzUMpDcmvXV2 RtPbiQ7hdWF5SC6zjNtiyjuTtL9q909Nibe/rAl92I4oZKPmco7+5r+17PJHi5cyqHtxTj1Fcj0eu WsNmhoHOEay+b/1UnQdzpw==; In-Reply-To: <87bjzfuzaq.fsf@melete.silentflame.com> (message from Sean Whitton on Sun, 20 Oct 2024 13:19:09 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293934 Archived-At: > From: Sean Whitton > Cc: 64055@debbugs.gnu.org, dgutov@yandex.ru, Morgan.J.Smith@outlook.com > Date: Sun, 20 Oct 2024 13:19:09 +0800 > > > When I do the above, I get an error message: > > > > vc-do-command: Failed (status 128): git --no-pager commit --only > > --allow-empty -F c:/Users/EliZ/AppData/Local/Temp/git-msgWaNflu > > > > and the *vc* buffer says: > > > > fatal: No paths with --include/--only does not make sense. > > > > It's possible my Git is very old, but shouldn't this command work with > > old versions as well? > > I've looked into it and what's required is Git 2.11.1 from early 2017. So someone will have to test the patch on Windows with a new en ough Git version. > I think we can support older by stashing and unstashing. So please try > the attached patch, which does that. This seems to work without any errors, and the *vc* buffer says Successfully rebased and updated refs/heads/master. But the log message is not updated, neither in the *vc-change-log* buffer nor if I manually invoke "git log" from the shell prompt. It sounds like the commit message was not amended. "git stash list" also shows no relevant stashes. Let me know how can I help you debug this.