From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73952: 30.0.91; [PATCH] Fix error when an Eshell glob has no results and 'eshell-glob-splice-results' is t Date: Tue, 22 Oct 2024 20:43:43 +0300 Message-ID: <867ca0f2y8.fsf@gnu.org> References: <089549bf-e927-c8c6-d6ac-a2df9731d732@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37999"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73952@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 22 19:44:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3Iw7-0009m2-3o for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Oct 2024 19:44:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3Ivt-0007BX-Cz; Tue, 22 Oct 2024 13:44:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Ivr-0007BA-1E for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2024 13:44:35 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Ivq-00051J-II for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2024 13:44:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=Wjazgowiwq6YpafJUX2/pmwZ5WkbGDW9RbnfRnLJv8s=; b=mHi22zIKsiA4DE+tlhYzlPHgOqj4CPmF9NMKYPc/cwcIHsKcqXetuOY/KTuy5h2h1XKTa74zcH7S/vnQoIcMd81sDzUrShLE6C/LrFvR/e1J/6QMaGpsfb7QM/Rh4G9sT5wymSWic52Hwe1y/zsQTxuOIwIO9pcr8+RdcPALFMX8jtR2qQXeXYZhKSl38kCUFbaTuw9c25bGSbNeamH7NAgIi8qdGQJV+RQvmkOcibA6+ABcMBvqNfrLkfOHXjR3PJ065oGukF+XEMb8ySaVj6HR6g0uCwunawH0AuL7DiRIc03Z+ZRsMTrwhBG3cii0DV6lyXzSp663GHQDYiuNyA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t3IwI-0006ne-Cl for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2024 13:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Oct 2024 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73952 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73952-submit@debbugs.gnu.org id=B73952.172961906526077 (code B ref 73952); Tue, 22 Oct 2024 17:45:02 +0000 Original-Received: (at 73952) by debbugs.gnu.org; 22 Oct 2024 17:44:25 +0000 Original-Received: from localhost ([127.0.0.1]:57144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3Ivg-0006mX-Pj for submit@debbugs.gnu.org; Tue, 22 Oct 2024 13:44:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3Ive-0006mG-GG for 73952@debbugs.gnu.org; Tue, 22 Oct 2024 13:44:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Iv6-0004v9-Qg; Tue, 22 Oct 2024 13:43:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Wjazgowiwq6YpafJUX2/pmwZ5WkbGDW9RbnfRnLJv8s=; b=VP0VMBwHePYZ Uw5lDrRGZYQW23esKcYWoP20vYEVpceybqUHjs+eQNgMW6ZU+tYO3DpOXvaBIT9yfyOrPgxk4vxvC oMGbI7a4ktQOQSCXRZItjQnhnrqJ/Ga37t55Zr3GQEmzLuBKVuc5TPGa7viJJyo9yxjeQQ+s9v0R1 Afo/rtJsUt4X1jl4wyIgXC8LvabPSw+R/xRAC/Vh352vP9qmQiOx0XXzpFWRCEkcqo4FVOmf4Ib0W hgDaA8Jko0VUvPkLPdCf1F2BtiiEFDZH8BCTbU6SiWVzVrODDl4qsxztXj/apyyg8OhZ290m47R2M +88pi8dwr6UbasSepiOQtg==; In-Reply-To: <089549bf-e927-c8c6-d6ac-a2df9731d732@gmail.com> (message from Jim Porter on Tue, 22 Oct 2024 09:57:42 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294121 Archived-At: > Cc: eliz@gnu.org > Date: Tue, 22 Oct 2024 09:57:42 -0700 > From: Jim Porter > > ~ $ (setq eshell-glob-splice-results t) > t > ~ $ echo /ssh:localhost:~/file.txt > /ssh:localhost:~/file.txt > ~ $ echo /ssh:localhost:~/file.txt > Wrong type argument: listp, "/ssh:localhost:~/file.txt" > > The third command should have the same result as the second (the second > works because Tramp isn't loaded yet at the time). > > This is a bug in a new Eshell feature in Emacs 30 and thankfully has an > easy fix (see attached). Eli, is this ok for the release branch? Yes, thanks.