From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74287: [PATCH] Rework history Isearch for Eshell Date: Wed, 27 Nov 2024 11:07:07 +0530 Message-ID: <867c8pxmnw.fsf@gmx.net> References: <871pzjkhmm.fsf@pengjiz.com> <8c80ae91-476e-e665-43be-86d72fb57ed1@gmail.com> <86v7waz603.fsf@gmx.net> <6fdd8386-8915-e3a8-046a-b18750a7057d@gmail.com> Reply-To: James Thomas Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36849"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74287@debbugs.gnu.org, Sean Whitton , Pengji Zhang , Juri Linkov To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 27 06:38:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tGAkv-0009Q3-15 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Nov 2024 06:38:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tGAkb-0002Gh-K6; Wed, 27 Nov 2024 00:38:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGAkW-00020k-09 for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2024 00:38:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tGAkV-0001YZ-Jm for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2024 00:38:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=XDvNL2HPPOlN52bGBLCPhwSFEmimsAQmtKqbCSW2LBQ=; b=S4nKCWiYbmGqa/DnhioXHAbH9tqmBRe8VPPGf/hU2bDycD5YzJloDYwguDOA1TGw4j/eeV6rI3CyjM//BRmTl6IsK1k7vrKnrTU0ft500uyzcs6xB4MRIsE8UhlAbp/vu1wN1lsYElJd/RCIH32W7FYaKzXWOtW/1iwuEUu25YG0AuIZqmeve3MEI7hPRILJwloCaGslPrwKbKV4ZBaTX+trQyG9tmsrfGCG2dkF0NJ48LzClzmS47hG9aCaF02Rdy31NgMxa5rhzBMUzLZoeeWFDa7kmlIOqY9CuyhdXHJTjF/0A/M0trL+tdmEjbvdfYuQpQI6GHJRwGi7YDFfMA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tGAkU-0000Vw-HX for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2024 00:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Nov 2024 05:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74287 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74287-submit@debbugs.gnu.org id=B74287.17326858481929 (code B ref 74287); Wed, 27 Nov 2024 05:38:02 +0000 Original-Received: (at 74287) by debbugs.gnu.org; 27 Nov 2024 05:37:28 +0000 Original-Received: from localhost ([127.0.0.1]:57981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGAjw-0000V0-Dw for submit@debbugs.gnu.org; Wed, 27 Nov 2024 00:37:28 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:50217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGAju-0000Um-JQ for 74287@debbugs.gnu.org; Wed, 27 Nov 2024 00:37:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1732685835; x=1733290635; i=jimjoe@gmx.net; bh=XDvNL2HPPOlN52bGBLCPhwSFEmimsAQmtKqbCSW2LBQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=lxBleLBT4XAQ4AxpSFtCroRsp4Md4e0e/Es+Y97ATnWGY2vgATq9uEpEv0F9cVb3 GYmxE95FBXYC3rawMIsgEqBjf8otU5iodhVBC8AE9etYNV/KHSYPUpv0aSFWZa5rw 49uZNdmJgAseeoVBuuCKQbK+HMAPpFFqfq+KhltPWk61wpeLA+x7Iy9A4JRI5+kA6 ZtScMfVq5geMP5VyTh87vvqoB3xDgVIyWLEQl5Y/kWSb1PB2INfYinZyZjbyfZT+R AC6WN1WhpdPja/82uuOAsR+6boRKj98d7wWdzRar+DJ6JJo7D50aoG08Tr4j58x8c BYMtxfmJ9u5RUe3G0g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from user-Inspiron-3493 ([42.108.29.45]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MjjCF-1tzw1K49uN-00aOXe; Wed, 27 Nov 2024 06:37:14 +0100 In-Reply-To: <6fdd8386-8915-e3a8-046a-b18750a7057d@gmail.com> (Jim Porter's message of "Tue, 26 Nov 2024 09:00:13 -0800") X-Provags-ID: V03:K1:G/DRbnwMAz7smcDMZDl0eS570dd6nMcfYy36PfWdCQGUZBppePN TIl2jGEkKnR8Ebrimr7gQcCNGjPV3cMhEH/SYlXWaB/uKPip6q4j/w0XO0JaTq64AULqK4a vPXjl7SxX5BkRyFzJMLTiw+d3RguO2VmyHvlsUH/O9Oy4/HwBCmjW7ZwTh+G2aAypkj6B3W pWGrGiWSbRrnWtQK1YwTA== UI-OutboundReport: notjunk:1;M01:P0:HQm0W8WQVXI=;JllORWN0aTdLCkFgorbt4jYG1G0 7vKGBSXCnAPzRgKzwEyRVOCbrdBdX9YalKMuzXgq8P39omgvUEzcJEM0t9KawROrc8HOR91KR raHi4VgO6zmdUQ7T54rik3s0tWtPFD04/WIj60IqK6JVpPfrI5wTENMy71HMLS6rkoYS0bRz/ Iqem+iSSZHiEb7xLttqTG4BVDBG3al81hSNXPeVFIGWJc9nptxKxN/iRzhGKfq15VcmvXL9iS mJHQcZnYrEVVG+UhLG1oaRf9NdyeNxPWxPZWh9QQ1V0JmhGy8eXiFNiwYlzFi1vLePnnkPnVC dx6OMZII775lmSd1CEsBtMuX4CZq0xd97HgjY7XCAXPp2NsqDOgsdxCBB0q5GG6f8evd2xkIM nxd9HiN47DYbsAJ/ixOyFJ9KYbwaZvyzxH3MGgiGWp11ZVaeg/0EWEedYFT0daPY8SSqg44m2 4ah30Mz3CyBx4+qu7u2MPmwwpOs7dQ3D2RPxmKbLGeHOyzgglnXmUDLCG+8akUIM90cmAiQNO h5ClbdZwKQsvA2N51qBiZ1mKiN6U17ATAVc7QR63NhIZliQPgkmyLr/XsL5nDnzK5DuT5bitu MhDihWCxkY/Kt5PVcc/napJKdxTyXoGxjo4nH4Elz0W8dIq/12PauxrnNGboUbRJySwL2Vjh9 lcTz/hhP2jg4ER5OiGacf7TGka45XfZ+AUQlJzADNY31ms0MsInQkQSPEG907WDSaZdYEdMCx W+Ordpk8zgvFwFTnjG46cH57PgXqp41fT5DNtx2A3pqffFhka6mWnidkfS/AQTfDnALTLTsL X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296018 Archived-At: Jim Porter wrote: > On 11/26/2024 1:41 AM, James Thomas via Bug reports for GNU Emacs, the > Swiss army knife of text editors wrote: >> My 2c: I now think it's better to hold out for something with way less >> code, using capf. > > Like mentioned in the emacs-devel list, that's probably how *I'd* want > a command history search implementation to use, but I also think that > an Isearch interface makes a lot of sense as an option, depending on > user preferences. As far as I can tell, we'd have to write different > code for each of these styles (i.e. you can't just make Isearch use > capf). Though as mentioned I'm not very familiar with Isearch's > internals. > > So long as this doesn't prevent a capf-based implementation (and I'm > guessing it wouldn't, since that would just be a new option), I think > we could merge this patch. Okay. In that case, my preference would be for it to be a separate module ala eshell-smart et. al., if possible; the motive being easing the maintenance burden. > I also prefer to have Shell and Eshell work the same way unless > there's some compelling reason why they should be different. Shell could change to be like eshell, for that, no? (like Wittgenstein's bit with the ruler) ;-) --