bug#73401: [PATCH] Make window dividers and internal border respect alpha background

bug#73401: [PATCH] Make window dividers and internal border respect alpha background

[Garklein]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

Hello,

I'm using EXWM with thick window dividers and internal borders. These
areas currently aren't affected by the alpha-background frame
parameter, which looks very ugly. I can't think of any reasons why
anyone would want this, so I think it's just an oversight. This patch
just makes them respect it.

[-- Attachment #2: dividers-border-transparent.patch --]
[-- Type: text/x-patch, Size: 2772 bytes --]

diff --git a/src/xterm.c b/src/xterm.c
index 0c20d38..7f665d8 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -7497,13 +7497,13 @@ x_draw_window_divider (struct window *w, int x0, int x1, int y0, int y1)
     {
       XSetForeground (display, f->output_data.x->normal_gc, color_first);
       x_fill_rectangle (f, f->output_data.x->normal_gc,
-			x0, y0, 1, y1 - y0, false);
+			x0, y0, 1, y1 - y0, true);
       XSetForeground (display, f->output_data.x->normal_gc, color);
       x_fill_rectangle (f, f->output_data.x->normal_gc,
-			x0 + 1, y0, x1 - x0 - 2, y1 - y0, false);
+			x0 + 1, y0, x1 - x0 - 2, y1 - y0, true);
       XSetForeground (display, f->output_data.x->normal_gc, color_last);
       x_fill_rectangle (f, f->output_data.x->normal_gc,
-			x1 - 1, y0, 1, y1 - y0, false);
+			x1 - 1, y0, 1, y1 - y0, true);
     }
   else if ((x1 - x0 > y1 - y0) && (y1 - y0 >= 3))
     /* A horizontal divider, at least three pixels high: Draw first and
@@ -7511,13 +7511,13 @@ x_draw_window_divider (struct window *w, int x0, int x1, int y0, int y1)
     {
       XSetForeground (display, f->output_data.x->normal_gc, color_first);
       x_fill_rectangle (f, f->output_data.x->normal_gc,
-			x0, y0, x1 - x0, 1, false);
+			x0, y0, x1 - x0, 1, true);
       XSetForeground (display, f->output_data.x->normal_gc, color);
       x_fill_rectangle (f, f->output_data.x->normal_gc,
-			x0, y0 + 1, x1 - x0, y1 - y0 - 2, false);
+			x0, y0 + 1, x1 - x0, y1 - y0 - 2, true);
       XSetForeground (display, f->output_data.x->normal_gc, color_last);
       x_fill_rectangle (f, f->output_data.x->normal_gc,
-			x0, y1 - 1, x1 - x0, 1, false);
+			x0, y1 - 1, x1 - x0, 1, true);
     }
   else
     {
@@ -7525,7 +7525,7 @@ x_draw_window_divider (struct window *w, int x0, int x1, int y0, int y1)
        differently.  */
       XSetForeground (display, f->output_data.x->normal_gc, color);
       x_fill_rectangle (f, f->output_data.x->normal_gc,
-			x0, y0, x1 - x0, y1 - y0, false);
+			x0, y0, x1 - x0, y1 - y0, true);
     }
 }
 
@@ -7732,11 +7732,11 @@ x_clear_under_internal_border (struct frame *f)
 	  GC gc = f->output_data.x->normal_gc;
 
 	  XSetForeground (display, gc, color);
-	  x_fill_rectangle (f, gc, 0, margin, width, border, false);
-	  x_fill_rectangle (f, gc, 0, 0, border, height, false);
-	  x_fill_rectangle (f, gc, width - border, 0, border, height, false);
+	  x_fill_rectangle (f, gc, 0, margin, width, border, true);
+	  x_fill_rectangle (f, gc, 0, 0, border, height, true);
+	  x_fill_rectangle (f, gc, width - border, 0, border, height, true);
 	  x_fill_rectangle (f, gc, 0, height - bottom_margin - border,
-			    width, border, false);
+			    width, border, true);
 	  XSetForeground (display, gc, FRAME_FOREGROUND_PIXEL (f));
 	}
       else

bug#73401: [PATCH] Make window dividers and internal border respect alpha background

[Eli Zaretskii]

> From: Garklein <garklein97@gmail.com>
> Date: Fri, 20 Sep 2024 14:25:14 -0400
> 
> I'm using EXWM with thick window dividers and internal borders. These
> areas currently aren't affected by the alpha-background frame
> parameter, which looks very ugly. I can't think of any reasons why
> anyone would want this, so I think it's just an oversight. This patch
> just makes them respect it.

Thanks.  Po Lu, any comments?

> diff --git a/src/xterm.c b/src/xterm.c
> index 0c20d38..7f665d8 100644
> --- a/src/xterm.c
> +++ b/src/xterm.c
> @@ -7497,13 +7497,13 @@ x_draw_window_divider (struct window *w, int x0, int x1, int y0, int y1)
>      {
>        XSetForeground (display, f->output_data.x->normal_gc, color_first);
>        x_fill_rectangle (f, f->output_data.x->normal_gc,
> -			x0, y0, 1, y1 - y0, false);
> +			x0, y0, 1, y1 - y0, true);
>        XSetForeground (display, f->output_data.x->normal_gc, color);
>        x_fill_rectangle (f, f->output_data.x->normal_gc,
> -			x0 + 1, y0, x1 - x0 - 2, y1 - y0, false);
> +			x0 + 1, y0, x1 - x0 - 2, y1 - y0, true);
>        XSetForeground (display, f->output_data.x->normal_gc, color_last);
>        x_fill_rectangle (f, f->output_data.x->normal_gc,
> -			x1 - 1, y0, 1, y1 - y0, false);
> +			x1 - 1, y0, 1, y1 - y0, true);
>      }
>    else if ((x1 - x0 > y1 - y0) && (y1 - y0 >= 3))
>      /* A horizontal divider, at least three pixels high: Draw first and
> @@ -7511,13 +7511,13 @@ x_draw_window_divider (struct window *w, int x0, int x1, int y0, int y1)
>      {
>        XSetForeground (display, f->output_data.x->normal_gc, color_first);
>        x_fill_rectangle (f, f->output_data.x->normal_gc,
> -			x0, y0, x1 - x0, 1, false);
> +			x0, y0, x1 - x0, 1, true);
>        XSetForeground (display, f->output_data.x->normal_gc, color);
>        x_fill_rectangle (f, f->output_data.x->normal_gc,
> -			x0, y0 + 1, x1 - x0, y1 - y0 - 2, false);
> +			x0, y0 + 1, x1 - x0, y1 - y0 - 2, true);
>        XSetForeground (display, f->output_data.x->normal_gc, color_last);
>        x_fill_rectangle (f, f->output_data.x->normal_gc,
> -			x0, y1 - 1, x1 - x0, 1, false);
> +			x0, y1 - 1, x1 - x0, 1, true);
>      }
>    else
>      {
> @@ -7525,7 +7525,7 @@ x_draw_window_divider (struct window *w, int x0, int x1, int y0, int y1)
>         differently.  */
>        XSetForeground (display, f->output_data.x->normal_gc, color);
>        x_fill_rectangle (f, f->output_data.x->normal_gc,
> -			x0, y0, x1 - x0, y1 - y0, false);
> +			x0, y0, x1 - x0, y1 - y0, true);
>      }
>  }
>  
> @@ -7732,11 +7732,11 @@ x_clear_under_internal_border (struct frame *f)
>  	  GC gc = f->output_data.x->normal_gc;
>  
>  	  XSetForeground (display, gc, color);
> -	  x_fill_rectangle (f, gc, 0, margin, width, border, false);
> -	  x_fill_rectangle (f, gc, 0, 0, border, height, false);
> -	  x_fill_rectangle (f, gc, width - border, 0, border, height, false);
> +	  x_fill_rectangle (f, gc, 0, margin, width, border, true);
> +	  x_fill_rectangle (f, gc, 0, 0, border, height, true);
> +	  x_fill_rectangle (f, gc, width - border, 0, border, height, true);
>  	  x_fill_rectangle (f, gc, 0, height - bottom_margin - border,
> -			    width, border, false);
> +			    width, border, true);
>  	  XSetForeground (display, gc, FRAME_FOREGROUND_PIXEL (f));
>  	}
>        else

bug#73401: [PATCH] Make window dividers and internal border respect alpha background

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Garklein <garklein97@gmail.com>
>> Date: Fri, 20 Sep 2024 14:25:14 -0400
>> 
>> I'm using EXWM with thick window dividers and internal borders. These
>> areas currently aren't affected by the alpha-background frame
>> parameter, which looks very ugly. I can't think of any reasons why
>> anyone would want this, so I think it's just an oversight. This patch
>> just makes them respect it.
>
> Thanks.  Po Lu, any comments?

We agreed in a previous bug report that this is not an oversight, since
they are borders, not backgrounds.

bug#73401: [PATCH] Make window dividers and internal border respect alpha background

[Garklein]

Would it be possible to have an option to make them transparent? It
makes it look a lot better for EXWM.

On Sat, Sep 28, 2024 at 6:40 AM Po Lu <luangruo@yahoo.com> wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Garklein <garklein97@gmail.com>
> >> Date: Fri, 20 Sep 2024 14:25:14 -0400
> >>
> >> I'm using EXWM with thick window dividers and internal borders. These
> >> areas currently aren't affected by the alpha-background frame
> >> parameter, which looks very ugly. I can't think of any reasons why
> >> anyone would want this, so I think it's just an oversight. This patch
> >> just makes them respect it.
> >
> > Thanks.  Po Lu, any comments?
>
> We agreed in a previous bug report that this is not an oversight, since
> they are borders, not backgrounds.

bug#73401: [PATCH] Make window dividers and internal border respect alpha background

[Eli Zaretskii]

Ping!  Po Lu, can you answer the OP?

> From: Garklein <garklein97@gmail.com>
> Date: Sun, 29 Sep 2024 15:37:58 -0400
> Cc: Eli Zaretskii <eliz@gnu.org>, 73401@debbugs.gnu.org
> 
> Would it be possible to have an option to make them transparent? It
> makes it look a lot better for EXWM.
> 
> On Sat, Sep 28, 2024 at 6:40 AM Po Lu <luangruo@yahoo.com> wrote:
> >
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > >> From: Garklein <garklein97@gmail.com>
> > >> Date: Fri, 20 Sep 2024 14:25:14 -0400
> > >>
> > >> I'm using EXWM with thick window dividers and internal borders. These
> > >> areas currently aren't affected by the alpha-background frame
> > >> parameter, which looks very ugly. I can't think of any reasons why
> > >> anyone would want this, so I think it's just an oversight. This patch
> > >> just makes them respect it.
> > >
> > > Thanks.  Po Lu, any comments?
> >
> > We agreed in a previous bug report that this is not an oversight, since
> > they are borders, not backgrounds.
> 

bug#73401: [PATCH] Make window dividers and internal border respect alpha background

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

> Ping!  Po Lu, can you answer the OP?
>
>> From: Garklein <garklein97@gmail.com>
>> Date: Sun, 29 Sep 2024 15:37:58 -0400
>> Cc: Eli Zaretskii <eliz@gnu.org>, 73401@debbugs.gnu.org
>> 
>> Would it be possible to have an option to make them transparent? It
>> makes it look a lot better for EXWM.

Yes, but I won't be implementing it myself till Emacs 30 is released.
In the interim, patches welcome.

bug#73401: [PATCH] Make window dividers and internal border respect alpha background

[Garklein]

[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]

Here is a patch that adds this option as a frame parameter.

I hope I did everything correctly, but I have never worked with the
Emacs C source before, so I probably made some mistakes in style or
logic.

Also, should this be factored out so that `border-alpha-background' is
its own parameter? In that case, a lot of functions would need to be
changed (the `respect-alpha-background' parameter in many xterm.c
functions would probably be changed to just a `double alpha` or
something like that). I am up for that, but I'm not sure if it would
be a helpful change.

Please let me know how it looks!


On Sat, Oct 12, 2024 at 8:38 PM Po Lu <luangruo@yahoo.com> wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Ping!  Po Lu, can you answer the OP?
> >
> >> From: Garklein <garklein97@gmail.com>
> >> Date: Sun, 29 Sep 2024 15:37:58 -0400
> >> Cc: Eli Zaretskii <eliz@gnu.org>, 73401@debbugs.gnu.org
> >>
> >> Would it be possible to have an option to make them transparent? It
> >> makes it look a lot better for EXWM.
>
> Yes, but I won't be implementing it myself till Emacs 30 is released.
> In the interim, patches welcome.

[-- Attachment #2: borders-respect-alpha-background.patch --]
[-- Type: application/x-patch, Size: 12540 bytes --]

bug#73401: [PATCH] Make window dividers and internal border respect alpha background

[Eli Zaretskii]

> From: Garklein <garklein97@gmail.com>
> Date: Sat, 23 Nov 2024 16:56:26 -0500
> Cc: Eli Zaretskii <eliz@gnu.org>, 73401@debbugs.gnu.org
> 
> Here is a patch that adds this option as a frame parameter.
> 
> I hope I did everything correctly, but I have never worked with the
> Emacs C source before, so I probably made some mistakes in style or
> logic.
> 
> Also, should this be factored out so that `border-alpha-background' is
> its own parameter? In that case, a lot of functions would need to be
> changed (the `respect-alpha-background' parameter in many xterm.c
> functions would probably be changed to just a `double alpha` or
> something like that). I am up for that, but I'm not sure if it would
> be a helpful change.
> 
> Please let me know how it looks!

Po Lu, any comments?

bug#73401: [PATCH] Make window dividers and internal border respect alpha background

[Garklein]

Any updates on this patch?

On Sat, Nov 30, 2024 at 5:24 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: Garklein <garklein97@gmail.com>
> > Date: Sat, 23 Nov 2024 16:56:26 -0500
> > Cc: Eli Zaretskii <eliz@gnu.org>, 73401@debbugs.gnu.org
> >
> > Here is a patch that adds this option as a frame parameter.
> >
> > I hope I did everything correctly, but I have never worked with the
> > Emacs C source before, so I probably made some mistakes in style or
> > logic.
> >
> > Also, should this be factored out so that `border-alpha-background' is
> > its own parameter? In that case, a lot of functions would need to be
> > changed (the `respect-alpha-background' parameter in many xterm.c
> > functions would probably be changed to just a `double alpha` or
> > something like that). I am up for that, but I'm not sure if it would
> > be a helpful change.
> >
> > Please let me know how it looks!
>
> Po Lu, any comments?

bug#73401: [PATCH] Make window dividers and internal border respect alpha background

[Eli Zaretskii]

Ping! Po Lu, any comments?

> From: Garklein <garklein97@gmail.com>
> Date: Wed, 11 Dec 2024 15:51:16 -0500
> Cc: luangruo@yahoo.com, 73401@debbugs.gnu.org
> 
> Any updates on this patch?
> 
> On Sat, Nov 30, 2024 at 5:24 AM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > > From: Garklein <garklein97@gmail.com>
> > > Date: Sat, 23 Nov 2024 16:56:26 -0500
> > > Cc: Eli Zaretskii <eliz@gnu.org>, 73401@debbugs.gnu.org
> > >
> > > Here is a patch that adds this option as a frame parameter.
> > >
> > > I hope I did everything correctly, but I have never worked with the
> > > Emacs C source before, so I probably made some mistakes in style or
> > > logic.
> > >
> > > Also, should this be factored out so that `border-alpha-background' is
> > > its own parameter? In that case, a lot of functions would need to be
> > > changed (the `respect-alpha-background' parameter in many xterm.c
> > > functions would probably be changed to just a `double alpha` or
> > > something like that). I am up for that, but I'm not sure if it would
> > > be a helpful change.
> > >
> > > Please let me know how it looks!
> >
> > Po Lu, any comments?
>