From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75291: Redisplay not updating fringe when face filter changes Date: Fri, 03 Jan 2025 21:31:10 +0200 Message-ID: <867c7bheyp.fsf@gnu.org> References: <874j2h3yzb.fsf@dancol.org> <8634i1jeai.fsf@gnu.org> <87ttah2hcd.fsf@dancol.org> <86v7uxhv9c.fsf@gnu.org> <87ikqx2dwh.fsf@dancol.org> <86h66hhr3a.fsf@gnu.org> <87ldvrajym.fsf@dancol.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8134"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75291@debbugs.gnu.org, mina86@mina86.com To: Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 03 20:32:25 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTnPF-0001ur-11 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Jan 2025 20:32:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTnOw-0006sc-ER; Fri, 03 Jan 2025 14:32:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTnOt-0006sP-CN for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 14:32:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTnOt-0005Ht-3d for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 14:32:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=mERhp9GUvLVBRKCjdUwzNT0vIOcyyB7MoL0/BzF5Bn8=; b=M/fAzQ6G71hFcY2w42RQCF7k6YePoA/pzq60sHGhhHNCJxdoJBnIrbUlJVNzfgM6ekAz50x3xJNIxtpQyFgwHJHEk3A9asVYaOkPhW4CBeJ4H7X8dVbU7cz/MATBGn06+0gMjO4oJavt62nVx1sdTPrLx4xuJMgDI57b7aZcY+ouz6fdjtFzDhrnwLSIOEBqsSlViZJzb4Dt8l/vr79zVswTvf9SKc7fwJ+5V9NoXVaEPlo2uoN3alisoGokxANaaWjQ46qTlKlFP6zvFwbJaHLUbQAlYLOU5ZbafGBVqBDywCuEUPMEFVWyWDDnBEGn2Hj+o55WRcW5TQQLQagRRw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTnOr-0003zX-TE for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 14:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2025 19:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75291 X-GNU-PR-Package: emacs Original-Received: via spool by 75291-submit@debbugs.gnu.org id=B75291.173593268615187 (code B ref 75291); Fri, 03 Jan 2025 19:32:01 +0000 Original-Received: (at 75291) by debbugs.gnu.org; 3 Jan 2025 19:31:26 +0000 Original-Received: from localhost ([127.0.0.1]:52173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTnOH-0003ws-Je for submit@debbugs.gnu.org; Fri, 03 Jan 2025 14:31:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42894) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tTnOC-0003wM-P8 for 75291@debbugs.gnu.org; Fri, 03 Jan 2025 14:31:23 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTnO5-0005BK-5N; Fri, 03 Jan 2025 14:31:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mERhp9GUvLVBRKCjdUwzNT0vIOcyyB7MoL0/BzF5Bn8=; b=FVC9WEM4+RWS o9OLf02sVSbCwpEdDdvcE0skkBC2F5bqYxskH70YLmoGGFnzQEo2q40JGTzp+9Y1nSTMGoHQzD4LM 5naeTJAqCHyVGnUh6B5LYTVg57RnIkcEJFF8u6jbNWkV0Af/h0/+Zea7mNdODxwIrz2xPeeB4eR3m 8jhtQAvSlBunKeMiYgcmoQWsg2F3ddxcrsYjW9O0UK/7ul8PmlvdtSVA/NanNT9gtUrmaFVNZiT6E N+TRodXiwTE4rCkYYx3NWvBcNCvKfFAtVpr/3vXlUamtmxdv8j5lcBD1Pdymvg0+TqwWmBVzODsEF t//JkDrIGEBV0AgIe9awvw==; In-Reply-To: <87ldvrajym.fsf@dancol.org> (message from Daniel Colascione on Fri, 03 Jan 2025 12:25:05 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298302 Archived-At: > From: Daniel Colascione > Cc: 75291@debbugs.gnu.org, mina86@mina86.com > Date: Fri, 03 Jan 2025 12:25:05 -0500 > > > I think it depends on whether you use double-buffering (some people > > don't or cannot) and whether you have the mouse pointer over an Emacs > > frame. Also, depending on the GUI toolkit, the decorations might > > flicker. > > TTY windows don't have fringes, and the most commonly-used window > systems all do atomic updates nowadays. People still report flickering from time to time, so I don't think this never happens. > > So you want to add to display_line code that sets each glyph_row's > > redraw_fringe_bitmaps_p flag when the fringe face changes? That could > > probably work, provided that we disable redisplay optimizations which > > might avoid calling display_line (you will see that we already disable > > such optimizations when overlay_arrows_changed_p returns non-zero). > > We might actually need to disable more of the optimizations, because > > the overlay-arrow thing doesn't contradict the optimizations that > > scroll the pixels, something that reaction to changes in the fringe > > face cannot tolerate. > > That might work, but I don't think we even need anything that > complicated or low-level. Not many are using :filtered now, and those > that do big redraws anyway. How about this simpler code that gets us > correctness, albeit more conservatively? Doesn't that only support face remapping with :filtered attribute? What about the more general case where the fringe face is remapped in a way that's independent of the windows?