From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#52172: Fix vc-git--program-version to support Git for macOS version string Date: Mon, 6 Dec 2021 03:57:00 +0300 Message-ID: <86686f8f-9ec2-2047-46a1-dcc31d3cd1f8@yandex.ru> References: <87k0grxblx.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20414"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: 52172@debbugs.gnu.org, Dmitry Antipov To: Lars Ingebrigtsen , Justin Schell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 06 01:58:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mu2KY-000584-EH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Dec 2021 01:58:10 +0100 Original-Received: from localhost ([::1]:53260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mu2KX-0002Qr-7N for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Dec 2021 19:58:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mu2KQ-0002OB-M8 for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 19:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48477) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mu2KQ-0002IV-EB for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 19:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mu2KQ-0007oR-DL for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 19:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Dec 2021 00:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52172 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52172-submit@debbugs.gnu.org id=B52172.163875226330004 (code B ref 52172); Mon, 06 Dec 2021 00:58:02 +0000 Original-Received: (at 52172) by debbugs.gnu.org; 6 Dec 2021 00:57:43 +0000 Original-Received: from localhost ([127.0.0.1]:60023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mu2K6-0007ns-Uc for submit@debbugs.gnu.org; Sun, 05 Dec 2021 19:57:43 -0500 Original-Received: from mail-lf1-f50.google.com ([209.85.167.50]:35515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mu2K5-0007ne-Jd for 52172@debbugs.gnu.org; Sun, 05 Dec 2021 19:57:41 -0500 Original-Received: by mail-lf1-f50.google.com with SMTP id u3so21343568lfl.2 for <52172@debbugs.gnu.org>; Sun, 05 Dec 2021 16:57:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=589/oppxY4FIBU9Jc674h9D8hcwefyxiipV+vCrHyWM=; b=TIRyC7tRjBvBt1wN3jAdm2pQqWAIrr9lTw5YHsRSSf70w+Mu4mAQewOBv0uR+ysUF5 if/MXlTufvWHZIZo+DaDzmPHxUH9V0cB6RCuk746kk1751znTvodMWbayT9S3K4iEzPu jo3pw4ww8+03ulzgw3FOpn8F6N6uk5Rsj7ZcVNcTzAzfGqoru8+tRn0QTAedabdBuUGj woUsDMI8x3KLkNqUy2E9I1nQaSQRJfynqcxaXbPyp3uHWsaPA2BOOhqVvjj28RRULmwA 6Jwe22jIbYL8dWFg947BDIq56jyh/aOt5QIQ3mWOQrMprbRspDjYvyPZNJZ8S6vMeGFn vRgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=589/oppxY4FIBU9Jc674h9D8hcwefyxiipV+vCrHyWM=; b=7QB3f1nxiGuYIUYhuTDdg5VrYkPX5OQc8W2ib11l1Tp4R2THZImKsTfN07I7XQCGVe PmvlfUWZsPL0FCET65aKcaozZf3B0d/JFM3F1NWqioQ4qSS7gs3VJUL0UQrLdrN/Ag+H NYxZ4IUEs9HygX3zIa0lx35rNQKlFulFA+DCLtX8HBqzEVRL4bLmGhzPLd6WdTbqIOzX u+PEcqAHhXiRTAgq8O9twy12Q1EWRmEV0K+iNnSXgoNkaZ/LBYrc3+DhtON8On8KlyXV Bis8LppttzpCmI/ux6rCv+gKJFxrHd59HV12zXHKmCBe13feVs491sqSpVz/2pgOMxhd cKwA== X-Gm-Message-State: AOAM532o7FkqGnQRTSVytdxD3dr29x1GIIc2Axt/4M9en8xkZrhl8XBv 2nsqqEIva37TvTO5WUoARRg= X-Google-Smtp-Source: ABdhPJy3/WdPS0wbdIQ3iMAbq24YZ0+ItGQ3eNwL/KDMb4JYK4AiSC/GnAdrZTjtfMPnOdYQ7oPgWg== X-Received: by 2002:a05:6512:2605:: with SMTP id bt5mr17542821lfb.147.1638752255604; Sun, 05 Dec 2021 16:57:35 -0800 (PST) Original-Received: from [192.168.0.103] ([5.18.233.185]) by smtp.googlemail.com with ESMTPSA id q6sm1209510lfa.133.2021.12.05.16.57.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Dec 2021 16:57:35 -0800 (PST) In-Reply-To: <87k0grxblx.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221687 Archived-At: Hi Lars! On 29.11.2021 17:47, Lars Ingebrigtsen wrote: > Justin Schell writes: > >> `topic.fix-vc-git--program-version.ignore-trailing.patch` updates the >> regexp used to match numeric version strings that are a combination of >> digits and dots (starting with a digit), ignoring anything else that >> comes after. Any trailing dots are then stripped. This is more general >> than the current approach of supporting a numeric version string only, > I think this approach makes the most sense, but perhaps Dmitry has an > opinion here (added to the CCs). Looks good to me (especially with included tests). The trailing-dot-stripping approach, that is. I would even suggest to try to get it into emacs-28 (given that apparently that functionality has been broken in macOS for a long time). But then again, if it's only been reported now, maybe it's not hugely important and Emacs 28 can live without it.