* bug#45140: 28.0.50; rendering c source on the tty inside virtual console
@ 2020-12-09 17:34 rrandresf
2021-10-11 12:14 ` Stefan Kangas
2021-10-11 15:11 ` Alan Mackenzie
0 siblings, 2 replies; 5+ messages in thread
From: rrandresf @ 2020-12-09 17:34 UTC (permalink / raw)
To: 45140
[-- Attachment #1: Type: text/plain, Size: 64 bytes --]
Hi. Guys.
On emacs 27.1 emacs on the tty renders pretty fine.
[-- Attachment #2: 27.1 --]
[-- Type: image/png, Size: 26823 bytes --]
[-- Attachment #3: Type: text/plain, Size: 74 bytes --]
On emacs 28.0.50 the colors has changed (read quality was better on 27)
[-- Attachment #4: 28 --]
[-- Type: image/png, Size: 20956 bytes --]
[-- Attachment #5: Type: text/plain, Size: 36 bytes --]
Part of source code (Just in case)
[-- Attachment #6: src --]
[-- Type: text/plain, Size: 2572 bytes --]
// tx_ok set here in case of online; TODO: mark the retry case before calling this func
void edi_tracking_bean_check_ticket_status(edi_tracking_bean_t self) {
inv_company_t company_bean;
credentials_t credentials;
buffer_t text_4_template_xml;
buffer_t text_inc_as_json_data_ptr;
buffer_t text_out;
const char *template_name_4_verbosity;
Err error;
bool flag;
flag = true;
credentials = (credentials_t)objects_search(self-> app_objects, (int)credentials_free);
company_bean = credentials_get_company_bean(credentials);
// export_company_data_for_edi_ticket_status
text_inc_as_json_data_ptr = inv_company_short_info_for_getting_ticket_status_to_json(company_bean, edi_tracking_bean_get_ticket_number(self));
if (!text_inc_as_json_data_ptr || (buffer_len(text_inc_as_json_data_ptr) < 1)) {
fprintf(stderr, "Err\n edi_tracking_bean_check_ticket_status issue on inv_company_short_info_for_getting_ticket_status_to_json %s\n", (const char*)buffer_ptr(text_inc_as_json_data_ptr));
inv_error_bean_set_data_helper(contrErrElectronicInvoicePoliIssue, "edi_tracking_bean_check_ticket_status issue on inv_company_short_info_for_getting_ticket_status_to_json", &error);
flag = false;
}
//get_line_content_template
template_name_4_verbosity = "electronic_invoice_get_ticket_status";
text_out = buffer_alloc (DEFAULT_ARRAY_SIZE);
text_4_template_xml = buffer_alloc( DEFAULT_ARRAY_SIZE );
contr_print_get_printer_resource_template_from_database(credentials_get_conn(credentials), template_name_4_verbosity, text_4_template_xml, &error);
if (buffer_len(text_4_template_xml) < 1) {
fprintf(stderr, "Err\n edi_tracking_bean_check_ticket_status issue on contr_print_get_printer_template_from_database %s\n", template_name_4_verbosity);
inv_error_bean_set_data_helper(contrSaleErrPrintingIssue, "printer template is not present", &error);
flag = false;
}
if (flag) {
flag = contr_print_merge((const char*)buffer_ptr(text_inc_as_json_data_ptr), (const char*)buffer_ptr(text_4_template_xml), template_name_4_verbosity, text_out, &error);
if (flag) {
edi_tracking_bean_set_post_data_for_ticket_status(self, (const char*)buffer_ptr(text_out));
flag = _edi_tracking_bean_check_ticket_status_helper(self, credentials, &error); // send
if (flag) {
// if_ok, {printf log.info} {inspect and analyze xml_result -> <content> <statusCode>} {0127|0|98|99}
edi_tracking_bean_set_was_transaction_ok(self);
}
}
}
buffer_free(text_4_template_xml);
buffer_free(text_out);
}
[-- Attachment #7: Type: text/plain, Size: 3348 bytes --]
Best Regards
ps: Ctrl+Alt+F3 {for going to tty3; and then emacsclient -c -t}
In GNU Emacs 28.0.50 (build 2, armv7l-unknown-linux-gnueabihf, X toolkit, cairo version 1.17.3, Xaw3d scroll bars)
of 2020-12-09 built on sacsa
Windowing system distributor 'The X.Org Foundation', version 11.0.12009000
System Description: Arch Linux ARM
Configured using:
'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
--localstatedir=/var --with-x-toolkit=lucid --with-xft --without-gconf
--without-gsettings --with-modules
'--program-transform-name=s/^ctags$/ctags.emacs/' --without-pop
--with-wide-int --with-json=yes 'CFLAGS=-march=armv7-a -mfloat-abi=hard
-mfpu=vfpv3-d16 -O2 -pipe -fstack-protector-strong -fno-plt'
CPPFLAGS=-D_FORTIFY_SOURCE=2
LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'
Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GLIB NOTIFY
INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB
TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON
PDUMPER LCMS2
Important settings:
value of $LC_COLLATE: C
value of $LANG: en_US.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml easymenu mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting font-render-setting cairo x-toolkit x
multi-tty make-network-process emacs)
Memory information:
((conses 16 52810 10166)
(symbols 48 7064 1)
(strings 16 19280 2077)
(string-bytes 1 614498)
(vectors 16 12353)
(vector-slots 8 176032 10074)
(floats 8 23 43)
(intervals 40 236 6)
(buffers 872 10))
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#45140: 28.0.50; rendering c source on the tty inside virtual console
2020-12-09 17:34 bug#45140: 28.0.50; rendering c source on the tty inside virtual console rrandresf
@ 2021-10-11 12:14 ` Stefan Kangas
2021-10-11 15:11 ` Alan Mackenzie
1 sibling, 0 replies; 5+ messages in thread
From: Stefan Kangas @ 2021-10-11 12:14 UTC (permalink / raw)
To: rrandresf; +Cc: 45140, Alan Mackenzie
rrandresf@gmail.com writes:
> Hi. Guys.
>
> On emacs 27.1 emacs on the tty renders pretty fine.
>
>
>
> On emacs 28.0.50 the colors has changed (read quality was better on 27)
So I guess this is about highlighting in cc-mode? Alan, any idea if
anything has changed in this area?
Screenshots are in:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45140
> Part of source code (Just in case)
>
> // tx_ok set here in case of online; TODO: mark the retry case before calling this func
> void edi_tracking_bean_check_ticket_status(edi_tracking_bean_t self) {
> inv_company_t company_bean;
> credentials_t credentials;
> buffer_t text_4_template_xml;
> buffer_t text_inc_as_json_data_ptr;
> buffer_t text_out;
> const char *template_name_4_verbosity;
> Err error;
> bool flag;
>
> flag = true;
> credentials = (credentials_t)objects_search(self-> app_objects, (int)credentials_free);
> company_bean = credentials_get_company_bean(credentials);
>
> // export_company_data_for_edi_ticket_status
> text_inc_as_json_data_ptr = inv_company_short_info_for_getting_ticket_status_to_json(company_bean, edi_tracking_bean_get_ticket_number(self));
> if (!text_inc_as_json_data_ptr || (buffer_len(text_inc_as_json_data_ptr) < 1)) {
> fprintf(stderr, "Err\n edi_tracking_bean_check_ticket_status issue on inv_company_short_info_for_getting_ticket_status_to_json %s\n", (const char*)buffer_ptr(text_inc_as_json_data_ptr));
> inv_error_bean_set_data_helper(contrErrElectronicInvoicePoliIssue, "edi_tracking_bean_check_ticket_status issue on inv_company_short_info_for_getting_ticket_status_to_json", &error);
> flag = false;
> }
>
> //get_line_content_template
> template_name_4_verbosity = "electronic_invoice_get_ticket_status";
> text_out = buffer_alloc (DEFAULT_ARRAY_SIZE);
> text_4_template_xml = buffer_alloc( DEFAULT_ARRAY_SIZE );
> contr_print_get_printer_resource_template_from_database(credentials_get_conn(credentials), template_name_4_verbosity, text_4_template_xml, &error);
> if (buffer_len(text_4_template_xml) < 1) {
> fprintf(stderr, "Err\n edi_tracking_bean_check_ticket_status issue on contr_print_get_printer_template_from_database %s\n", template_name_4_verbosity);
> inv_error_bean_set_data_helper(contrSaleErrPrintingIssue, "printer template is not present", &error);
> flag = false;
> }
>
> if (flag) {
> flag = contr_print_merge((const char*)buffer_ptr(text_inc_as_json_data_ptr), (const char*)buffer_ptr(text_4_template_xml), template_name_4_verbosity, text_out, &error);
> if (flag) {
> edi_tracking_bean_set_post_data_for_ticket_status(self, (const char*)buffer_ptr(text_out));
> flag = _edi_tracking_bean_check_ticket_status_helper(self, credentials, &error); // send
> if (flag) {
> // if_ok, {printf log.info} {inspect and analyze xml_result -> <content> <statusCode>} {0127|0|98|99}
> edi_tracking_bean_set_was_transaction_ok(self);
> }
> }
> }
>
> buffer_free(text_4_template_xml);
> buffer_free(text_out);
> }
>
>
> Best Regards
> ps: Ctrl+Alt+F3 {for going to tty3; and then emacsclient -c -t}
>
>
> In GNU Emacs 28.0.50 (build 2, armv7l-unknown-linux-gnueabihf, X toolkit, cairo version 1.17.3, Xaw3d scroll bars)
> of 2020-12-09 built on sacsa
> Windowing system distributor 'The X.Org Foundation', version 11.0.12009000
> System Description: Arch Linux ARM
>
> Configured using:
> 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
> --localstatedir=/var --with-x-toolkit=lucid --with-xft --without-gconf
> --without-gsettings --with-modules
> '--program-transform-name=s/^ctags$/ctags.emacs/' --without-pop
> --with-wide-int --with-json=yes 'CFLAGS=-march=armv7-a -mfloat-abi=hard
> -mfpu=vfpv3-d16 -O2 -pipe -fstack-protector-strong -fno-plt'
> CPPFLAGS=-D_FORTIFY_SOURCE=2
> LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'
>
> Configured features:
> XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GLIB NOTIFY
> INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB
> TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON
> PDUMPER LCMS2
>
> Important settings:
> value of $LC_COLLATE: C
> value of $LANG: en_US.UTF-8
> locale-coding-system: utf-8-unix
>
> Major mode: Lisp Interaction
>
> Minor modes in effect:
> tooltip-mode: t
> global-eldoc-mode: t
> eldoc-mode: t
> electric-indent-mode: t
> mouse-wheel-mode: t
> tool-bar-mode: t
> menu-bar-mode: t
> file-name-shadow-mode: t
> global-font-lock-mode: t
> font-lock-mode: t
> blink-cursor-mode: t
> auto-composition-mode: t
> auto-encryption-mode: t
> auto-compression-mode: t
> line-number-mode: t
> transient-mark-mode: t
>
> Load-path shadows:
> None found.
>
> Features:
> (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
> rfc822 mml easymenu mml-sec epa derived epg epg-config gnus-util rmail
> rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
> eieio-loaddefs password-cache json map text-property-search time-date
> subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
> mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
> cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
> iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
> lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
> dnd fontset image regexp-opt fringe tabulated-list replace newcomment
> text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
> rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
> syntax facemenu font-core term/tty-colors frame minibuffer cl-generic
> cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
> korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
> european ethiopic indian cyrillic chinese composite charscript charprop
> case-table epa-hook jka-cmpr-hook help simple abbrev obarray
> cl-preloaded nadvice button loaddefs faces cus-face macroexp files
> window text-properties overlay sha1 md5 base64 format env code-pages
> mule custom widget hashtable-print-readable backquote threads dbusbind
> inotify lcms2 dynamic-setting font-render-setting cairo x-toolkit x
> multi-tty make-network-process emacs)
>
> Memory information:
> ((conses 16 52810 10166)
> (symbols 48 7064 1)
> (strings 16 19280 2077)
> (string-bytes 1 614498)
> (vectors 16 12353)
> (vector-slots 8 176032 10074)
> (floats 8 23 43)
> (intervals 40 236 6)
> (buffers 872 10))
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#45140: 28.0.50; rendering c source on the tty inside virtual console
2020-12-09 17:34 bug#45140: 28.0.50; rendering c source on the tty inside virtual console rrandresf
2021-10-11 12:14 ` Stefan Kangas
@ 2021-10-11 15:11 ` Alan Mackenzie
2021-10-15 3:27 ` andrés ramírez
1 sibling, 1 reply; 5+ messages in thread
From: Alan Mackenzie @ 2021-10-11 15:11 UTC (permalink / raw)
To: rrandresf; +Cc: 45140, Stefan Kangas
Hello, rrandresf.
Firstly, sorry about missing your bug report last December.
Secondly, it's great to see somebody else using the Linux tty!
On Wed, Dec 09, 2020 at 17:34:25 +0000, rrandresf@gmail.com wrote:
> Hi. Guys.
> On emacs 27.1 emacs on the tty renders pretty fine.
> On emacs 28.0.50 the colors has changed (read quality was better on 27)
It looks like the fontification was unfinished on that screen. For
example, strings and comments get fontified, but the variable
declarations didn't. I hope that was a bug in CC Mode which has long
been fixed. When that happens, there is often an error message in the
*Messages* buffer, which you can see with C-h e.
Was there anything else about the reduction in quality you mention? I
think your yellow strings was something you configured yourself, for
example.
Is the problem still there in the savannah master branch, or what has
now become the Emacs-28 release branch?
> Part of source code (Just in case)
[ .... Thanks! ]
> Best Regards
> ps: Ctrl+Alt+F3 {for going to tty3; and then emacsclient -c -t}
Yes. ;-)
> In GNU Emacs 28.0.50 (build 2, armv7l-unknown-linux-gnueabihf, X toolkit, cairo version 1.17.3, Xaw3d scroll bars)
> of 2020-12-09 built on sacsa
> Windowing system distributor 'The X.Org Foundation', version 11.0.12009000
> System Description: Arch Linux ARM
> Configured using:
> 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
> --localstatedir=/var --with-x-toolkit=lucid --with-xft --without-gconf
> --without-gsettings --with-modules
> '--program-transform-name=s/^ctags$/ctags.emacs/' --without-pop
> --with-wide-int --with-json=yes 'CFLAGS=-march=armv7-a -mfloat-abi=hard
> -mfpu=vfpv3-d16 -O2 -pipe -fstack-protector-strong -fno-plt'
> CPPFLAGS=-D_FORTIFY_SOURCE=2
> LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'
[ .... ]
--
Alan Mackenzie (Nuremberg, Germany).
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#45140: 28.0.50; rendering c source on the tty inside virtual console
2021-10-11 15:11 ` Alan Mackenzie
@ 2021-10-15 3:27 ` andrés ramírez
2021-10-24 7:58 ` Stefan Kangas
0 siblings, 1 reply; 5+ messages in thread
From: andrés ramírez @ 2021-10-15 3:27 UTC (permalink / raw)
To: Alan Mackenzie; +Cc: 45140, Stefan Kangas
Hi. Alan. Hi. Stefan.
My comments below.
>>>>> "Alan" == Alan Mackenzie <acm@muc.de> writes:
Alan> Hello, rrandresf. Firstly, sorry about missing your bug report last December.
Alan> Secondly, it's great to see somebody else using the Linux tty!
Right. Alan. tty is quick and awesome. Excellent for the eyes.
[...]
Alan> Is the problem still there in the savannah master branch, or what has now become the
Alan> Emacs-28 release branch?
I have just checked. That it has been fixed on the emacs-28 release
branch. So I think the bug could be closed. Thanks for work guys.
Best Regards
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#45140: 28.0.50; rendering c source on the tty inside virtual console
2021-10-15 3:27 ` andrés ramírez
@ 2021-10-24 7:58 ` Stefan Kangas
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Kangas @ 2021-10-24 7:58 UTC (permalink / raw)
To: andrés ramírez; +Cc: Alan Mackenzie, 45140-done
andrés ramírez <rrandresf@gmail.com> writes:
> Hi. Alan. Hi. Stefan.
> My comments below.
>
>>>>>> "Alan" == Alan Mackenzie <acm@muc.de> writes:
> Alan> Hello, rrandresf. Firstly, sorry about missing your bug report last December.
> Alan> Secondly, it's great to see somebody else using the Linux tty!
>
> Right. Alan. tty is quick and awesome. Excellent for the eyes.
>
> [...]
>
> Alan> Is the problem still there in the savannah master branch, or what has now become the
> Alan> Emacs-28 release branch?
>
> I have just checked. That it has been fixed on the emacs-28 release
> branch. So I think the bug could be closed. Thanks for work guys.
Thanks, I'm therefore closing this bug report.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-24 7:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-09 17:34 bug#45140: 28.0.50; rendering c source on the tty inside virtual console rrandresf
2021-10-11 12:14 ` Stefan Kangas
2021-10-11 15:11 ` Alan Mackenzie
2021-10-15 3:27 ` andrés ramírez
2021-10-24 7:58 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).