From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52248: Open hidden overlays in isearch-delete-char Date: Thu, 02 Dec 2021 21:56:02 +0200 Organization: LINKOV.NET Message-ID: <865ys6zsq5.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13043"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) To: 52248@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 02 21:00:40 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mssFz-0003IA-PZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Dec 2021 21:00:39 +0100 Original-Received: from localhost ([::1]:39270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mssFx-00018L-Nz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Dec 2021 15:00:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mssFS-00015a-Nc for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 15:00:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mssFO-00021q-JX for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 15:00:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mssFO-0002B6-F7 for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 15:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2021 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52248 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16384751718300 (code B ref -1); Thu, 02 Dec 2021 20:00:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Dec 2021 19:59:31 +0000 Original-Received: from localhost ([127.0.0.1]:49384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mssEt-00029o-2T for submit@debbugs.gnu.org; Thu, 02 Dec 2021 14:59:31 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:40086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mssEp-00029f-TV for submit@debbugs.gnu.org; Thu, 02 Dec 2021 14:59:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mssEp-0000Yk-Kj for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 14:59:27 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:54485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mssEm-0001x4-Az for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 14:59:27 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id BFD4C60006 for ; Thu, 2 Dec 2021 19:59:16 +0000 (UTC) Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221345 Archived-At: Tags: patch This is not a regression. While navigating forward with C-s in a buffer with invisible overlays such as when using outline-minor-mode with hidden outlines, it opens hidden overlays on the current match, and hides again when going to the next match. But going back with DEL (isearch-delete-char) doesn't reopen the hidden overlay on the previous match. Here is the fix: diff --git a/lisp/isearch.el b/lisp/isearch.el index fcb7d646c6..8421c5629b 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -2504,6 +2552,10 @@ isearch-delete-char (if (null (cdr isearch-cmds)) (ding) (isearch-pop-state)) + ;; When going back to the hidden match, reopen it. + (when (and (eq search-invisible 'open) isearch-hide-immediately isearch-other-end) + (isearch-range-invisible (min (point) isearch-other-end) + (max (point) isearch-other-end))) (isearch-update)) (defun isearch-del-char (&optional arg) --