unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luangruo@yahoo.com, 53170@debbugs.gnu.org
Subject: bug#53170: 29.0.50; Can't repetitively click next node button inside Info header line
Date: Wed, 12 Jan 2022 19:20:40 +0200	[thread overview]
Message-ID: <865yqpsznj.fsf@mail.linkov.net> (raw)
In-Reply-To: <83ee5e6nwk.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Jan 2022 22:03:07 +0200")

>> Then these bindings are interfering:
>>
>>     (define-key keymap [header-line down-mouse-1] 'mouse-drag-header-line)
>>     (define-key keymap [header-line mouse-1] 'mouse-select-window)
>>
>> The problem can be fixed by replacing these lines with:
>>
>>     (define-key keymap [header-line mouse-1] 'Info-mouse-follow-link)
>>
>> But I don't know how important is the feature of selecting/dragging the header-line?
>
> I don't think I understand how 2 clicks one after another are taken as
> a drag-mouse event.  Can you tell why this happens?

Actually, its's mouse-select-window that steals the click.
There is no need to bind mouse-1 to mouse-select-window
because the window is selected anyway, so this patch fixes
the reported problem:

diff --git a/lisp/info.el b/lisp/info.el
index f4f0f9790c..bb8cd0d312 100644
--- a/lisp/info.el
+++ b/lisp/info.el
@@ -4693,7 +4693,7 @@ Info-goto-emacs-key-command-node
 (defvar Info-link-keymap
   (let ((keymap (make-sparse-keymap)))
     (define-key keymap [header-line down-mouse-1] 'mouse-drag-header-line)
-    (define-key keymap [header-line mouse-1] 'mouse-select-window)
+    (define-key keymap [header-line mouse-1] 'Info-mouse-follow-link)
     (define-key keymap [header-line mouse-2] 'Info-mouse-follow-link)
     (define-key keymap [mouse-2] 'Info-mouse-follow-link)
     (define-key keymap [follow-link] 'mouse-face)
-- 






  reply	other threads:[~2022-01-12 17:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <877db7nhjn.fsf.ref@yahoo.com>
2022-01-11  2:16 ` bug#53170: 29.0.50; Can't repetitively click next node button inside Info header line Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-11  9:01   ` Juri Linkov
2022-01-11  9:40     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-11 13:26     ` Eli Zaretskii
2022-01-11 18:24       ` Juri Linkov
2022-01-11 18:55         ` Eli Zaretskii
2022-01-11 19:12           ` Juri Linkov
2022-01-11 20:03             ` Eli Zaretskii
2022-01-12 17:20               ` Juri Linkov [this message]
2022-01-12 17:29                 ` Eli Zaretskii
2022-01-24 18:56                   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865yqpsznj.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=53170@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).