From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51883: 29.0.50; Command to get accidentally deleted frames back Date: Sun, 30 Jan 2022 22:49:13 +0200 Organization: LINKOV.NET Message-ID: <865yq1dj81.fsf@mail.linkov.net> References: <87czn1gfb1.fsf@web.de> <838rxo0zk7.fsf@gnu.org> <86czk9kxm8.fsf@mail.linkov.net> <83ilu19n31.fsf@gnu.org> <86leyxjg7m.fsf@mail.linkov.net> <83h79l9jgp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25636"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: michael_heerdegen@web.de, gregory@heytings.org, monnier@iro.umontreal.ca, 51883@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 30 22:30:52 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEHmd-0006ZG-RY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jan 2022 22:30:51 +0100 Original-Received: from localhost ([::1]:42286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEHmc-0001Fo-MA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jan 2022 16:30:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEHlr-0000ln-3C for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 16:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44953) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEHlq-0000zI-Os for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 16:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEHlq-00038M-Lt for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 16:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jan 2022 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51883-submit@debbugs.gnu.org id=B51883.164357816011965 (code B ref 51883); Sun, 30 Jan 2022 21:30:02 +0000 Original-Received: (at 51883) by debbugs.gnu.org; 30 Jan 2022 21:29:20 +0000 Original-Received: from localhost ([127.0.0.1]:37856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEHl9-00036u-Lw for submit@debbugs.gnu.org; Sun, 30 Jan 2022 16:29:19 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:55739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEHl7-00036e-EF for 51883@debbugs.gnu.org; Sun, 30 Jan 2022 16:29:18 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 6B2681C0005; Sun, 30 Jan 2022 21:29:08 +0000 (UTC) In-Reply-To: <83h79l9jgp.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 30 Jan 2022 20:17:26 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225635 Archived-At: >> >> So all concerns raised by Eli are addressed now >> >> that make possible to enable it by default >> >> as was discussed on emacs-devel: >> > >> > Once again, please do NOT enable this by default, I didn't agree to >> > that. This feature should remain disabled by default for some time, >> > until we have enough information to discuss whether it should be >> > turned on by default. As discussed and agreed during its development. >> >> But after the recent discussion it was agreed to enable it by default >> after fixing raised concerns. Everything is fixed now. >> Should we restart the same discussion again? > > I see no need to restart that discussion, since we won't hear anything > new in it. We made a decision back then, and there's no burning > reason to change that decision, except that some people would like to > have that feature turned on -- they can tun it on in their > customizations. > > We discuss stuff and make decisions, and we should stick to our > decisions unless they turn out to be grave mistakes, which this one > isn't. Unfortunately, this is a grave mistake, so it needs more discussion on emacs-devel. >> >> @item C-x 5 u >> >> @kindex C-x 5 u >> >> @findex undelete-frame >> >> -@findex undelete-frame-mode >> >> -When @code{undelete-frame-mode} is enabled, undelete one of the 16 >> >> -most recently deleted frames. Without a prefix argument, undelete the >> >> -most recently deleted frame. With a numerical prefix argument between >> >> -1 and 16, where 1 is the most recently deleted frame, undelete the >> >> -corresponding deleted frame. >> >> +@findex undelete-frame-max >> >> +Undelete one of the recently deleted frames. The user option >> > >> > "One of the recently deleted frames" sounds like Emacs arbitrarily >> > decides which one. Which is not what you wanted to say, surely. >> >> This was copied from old text: "undelete one of the 16 most recently deleted frames". > > Does that mean we must blindly copy it, even if it is confusing? I will fix this, once the patch is accepted. >> >> +(defcustom undelete-frame-max 1 >> >> + "Maximum number of deleted frames before oldest are thrown away." >> > >> > This doesn't say how to disable the feature. >> >> This feature can be disabled by customizing it to 0. > > I know. But the doc string keeps silent on that. Will fix this as well. >> >> (bindings--define-key menu [undelete-last-deleted-frame] >> >> '(menu-item "Undelete Frame" undelete-frame >> >> - :enable (and undelete-frame-mode >> >> - (car undelete-frame--deleted-frames)) >> >> + :visible (car undelete-frame--deleted-frames) >> > >> > I think Gregory didn't like the disappearing item, and preferred it to >> > be visible at all times, even if disabled. >> >> The invisible item makes the already overly long menu shorter, >> especially for users who don't use frames. > > So you basically say we should disregard Gregory's opinion and prefer > yours? This definitely needs more discussion, so I'll post the problem's description on emacs-devel.