From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#14013: 24.3.50; dired-isearch-filenames-regexp is matching text outside filenames Date: Tue, 14 Jun 2022 19:31:42 +0300 Organization: LINKOV.NET Message-ID: <865yl3gqa9.fsf@mail.linkov.net> References: <87li9hk5e5.fsf@web.de> <87wqt1vd0o.fsf@mail.jurta.org> <87d2ut4mji.fsf@web.de> <87620lvavl.fsf@mail.jurta.org> <87zjxxsd6c.fsf@web.de> <87vc8ke4os.fsf@mail.jurta.org> <86zgmutwx9.fsf@mail.linkov.net> <87o83ab67d.fsf@web.de> <86r185520f.fsf@mail.linkov.net> <87czjn39yf.fsf@web.de> <86y2215rbn.fsf@mail.linkov.net> <87ee3tjecw.fsf@web.de> <87pmnap75m.fsf@web.de> <86mtha7y8w.fsf@mail.linkov.net> <877d8935sf.fsf@web.de> <861qygal8h.fsf@mail.linkov.net> <87ilpm2jan.fsf@web.de> <86czfgbh9i.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29081"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Stefan Monnier , 14013@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 14 19:02:52 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o19wJ-0007PW-6R for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jun 2022 19:02:51 +0200 Original-Received: from localhost ([::1]:44262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o19wH-0004l0-PN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jun 2022 13:02:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o19UQ-00082r-BG for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 12:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41697) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o19UP-0000IJ-W5 for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 12:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o19UP-0001dd-Q4 for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 12:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jun 2022 16:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14013 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14013-submit@debbugs.gnu.org id=B14013.16552243956238 (code B ref 14013); Tue, 14 Jun 2022 16:34:01 +0000 Original-Received: (at 14013) by debbugs.gnu.org; 14 Jun 2022 16:33:15 +0000 Original-Received: from localhost ([127.0.0.1]:35594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o19Te-0001cY-PT for submit@debbugs.gnu.org; Tue, 14 Jun 2022 12:33:14 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:35795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o19Tc-0001cI-P1 for 14013@debbugs.gnu.org; Tue, 14 Jun 2022 12:33:13 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id C8692FF806; Tue, 14 Jun 2022 16:33:04 +0000 (UTC) In-Reply-To: <86czfgbh9i.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 10 Jun 2022 19:44:09 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234516 Archived-At: > I generalized dired-isearch-search-filenames to a new function > that can search in any text property, so e.g. after evaluating > > (setq-local isearch-search-fun-function > (lambda () (isearch-search-fun-in-text-property 'face))) > > isearch will match .* in all fontified chunks, etc. I'm sure later someone might want to add more args such as e.g. text-property-search-forward has PROPERTY &optional VALUE PREDICATE ... So better to change the signature in anticipation of adding more args after PROPERTY: diff --git a/lisp/isearch.el b/lisp/isearch.el -(defun isearch-search-fun-in-text-property (property &optional search-fun) +(defun isearch-search-fun-in-text-property (search-fun property) diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el @@ -3208,7 +3208,7 @@ dired-isearch-search-filenames - (isearch-search-fun-in-text-property 'dired-filename (funcall orig-fun))) + (isearch-search-fun-in-text-property (funcall orig-fun) 'dired-filename))