From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#57082: 29.0.50; emacs-news-view-mode breakage Date: Tue, 09 Aug 2022 22:18:21 +0300 Organization: LINKOV.NET Message-ID: <865yj1p6o2.fsf@mail.linkov.net> References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17543"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Stephen Berman , 57082@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 09 21:23:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLUot-0004Rx-6l for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 21:23:15 +0200 Original-Received: from localhost ([::1]:37406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLUos-0008OE-94 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 15:23:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLUog-0008Kd-SW for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 15:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55347) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLUog-0007JI-Jv for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 15:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLUog-0006TO-Fl for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 15:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Aug 2022 19:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57082 X-GNU-PR-Package: emacs Original-Received: via spool by 57082-submit@debbugs.gnu.org id=B57082.166007294324809 (code B ref 57082); Tue, 09 Aug 2022 19:23:02 +0000 Original-Received: (at 57082) by debbugs.gnu.org; 9 Aug 2022 19:22:23 +0000 Original-Received: from localhost ([127.0.0.1]:45093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLUo2-0006S3-M8 for submit@debbugs.gnu.org; Tue, 09 Aug 2022 15:22:22 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:35223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLUnz-0006Ri-Vq for 57082@debbugs.gnu.org; Tue, 09 Aug 2022 15:22:20 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3D28A1BF206; Tue, 9 Aug 2022 19:22:11 +0000 (UTC) In-Reply-To: <874jylwa17.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 09 Aug 2022 20:23:48 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239213 Archived-At: >> The attached patch appears to fix the problems described above, but the >> only buffer using outline-minor-mode beside NEWS that I've tested it on >> is *Help* showing the output of describe-bindings, and the seems to work >> as expected with the patch (and due to the patch is not flagged as >> modified, though that isn't important for *Help*.) > > Thanks; patch applied to Emacs 29. I noticed more problems: arrow directions are inverted - when an outline is hidden the arrow direction is open; when it's shown then the button has the closed state. S-TAB (outline-cycle-buffer) is very slow: takes ~3 seconds on a small NEWS buffer. Also don't understand why is this change: (when outline-minor-mode-highlight - (if (and global-font-lock-mode (font-lock-specified-p major-mode)) - (progn - (font-lock-add-keywords nil outline-font-lock-keywords t) - (font-lock-flush)) - (outline-minor-mode-highlight-buffer))) + (when (and global-font-lock-mode (font-lock-specified-p major-mode)) + (font-lock-add-keywords nil outline-font-lock-keywords t) + (font-lock-flush)) + (outline-minor-mode-highlight-buffer)) `outline-minor-mode-highlight-buffer' is intended only for buffers that don't support font-lock highlighting. > The outline button stuff is still a work in progress, as you've found > out. I'm not quite sure whether it should be switched on by default in > NEWS buffers -- it doesn't seem to bring much value there. (As opposed > to in `describe-bindings', where it seems very helpful (since we're > starting out with some parts already folded.) It would be nicer if the color of the button depended on the outline's color, e.g. blue for the top-level blue outline face, etc. > So I'm pondering whether to add an additional mechanism to say whether a > mode is "opting in" to the buttons or not, but I'm not sure what that > should look like. Since outline-minor-mode-use-buttons uses buffer-match-p, it can have any condition, including a condition to exclude etc/NEWS, for example.