From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#63829: 29.0.90; project-find-file's future history breaks with common-parent-directory Date: Sun, 20 Aug 2023 20:13:51 +0300 Organization: LINKOV.NET Message-ID: <865y59n73s.fsf@mail.linkov.net> References: <16b64d95-35e9-ef94-2c54-17b670111f0f@gutov.dev> <86h6rnw7gm.fsf@mail.linkov.net> <3e404df1-b3a9-f9e3-4270-f42df8b704c7@gutov.dev> <87a5uti6mo.fsf@catern.com> <73a695f3-7c6a-0e50-41dd-61f8269f6ecf@gutov.dev> <875y5fitiq.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7809"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: sbaugh@catern.com, 63829@debbugs.gnu.org, Spencer Baugh To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 20 19:29:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXmEg-0001nm-IN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Aug 2023 19:29:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXmEX-0006bG-62; Sun, 20 Aug 2023 13:29:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXmEW-0006as-BQ for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 13:29:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXmEW-0002mt-2z for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 13:29:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXmEX-0004yN-Or for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 13:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 17:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63829 X-GNU-PR-Package: emacs Original-Received: via spool by 63829-submit@debbugs.gnu.org id=B63829.169255248819015 (code B ref 63829); Sun, 20 Aug 2023 17:29:01 +0000 Original-Received: (at 63829) by debbugs.gnu.org; 20 Aug 2023 17:28:08 +0000 Original-Received: from localhost ([127.0.0.1]:54779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXmDf-0004wX-U8 for submit@debbugs.gnu.org; Sun, 20 Aug 2023 13:28:08 -0400 Original-Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]:33883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXmDZ-0004uy-Sb for 63829@debbugs.gnu.org; Sun, 20 Aug 2023 13:28:02 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 2FA97C0002; Sun, 20 Aug 2023 17:27:52 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Thu, 17 Aug 2023 05:14:03 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268016 Archived-At: > +(defun project--expand-file-name (filename project) > + (when-let ((old-root (get-text-property 0 'project filename))) > + (abbreviate-file-name > + (expand-file-name > + (file-relative-name filename old-root) > + (project-root project))))) and > + (add-to-history 'file-name-history > + (propertize file 'project (project-root project)))) Then maybe better to simply add only the relative file name for optimization? Like this (add-to-history 'file-name-history (propertize file 'project-relative-name (file-relative-name file (project-root project)))))