unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Charles Gonnaud <charles.gonnaud@gmail.com>
Cc: 70485-done@debbugs.gnu.org
Subject: bug#70485: 30.0.50; Asymetrical margins break mode-line-right-align-edge
Date: Thu, 25 Apr 2024 19:36:47 +0300	[thread overview]
Message-ID: <865xw51js0.fsf@gnu.org> (raw)
In-Reply-To: <6eaaede9-97a5-4199-bf6c-52bb812e9007@gmail.com> (message from Charles Gonnaud on Sat, 20 Apr 2024 23:38:18 +0200)

> Date: Sat, 20 Apr 2024 23:38:18 +0200
> From: Charles Gonnaud <charles.gonnaud@gmail.com>
> 
> Hello to all,
> Thank you for your work maintaining emacs, this is my first bug report
> so please be indulgent.
> 
> *** Bug description
> 
> I use a minor-mode similar to olivetti
> (https://github.com/rnkn/olivetti), which uses margins to center the
> text in the window.
> 
> Playing around with the doom modeline, which copied emacs 30's
> implementation of `mode-line-right-align-edge', I noticed that setting
> a different margin on the left and right resulted in a cropped modeline
> to the right.
> 
> *** Suggested patch
> 
> In mode--line-format-right-align() (lisp/bindings.el:384)
> - (* (or (cdr (window-margins)) 1)
> + (* (or (car (window-margins)) 0)

Thanks, you are right.  I've now installed your proposed change on the
master branch, and I'm therefore closing this bug.





      reply	other threads:[~2024-04-25 16:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-20 21:38 bug#70485: 30.0.50; Asymetrical margins break mode-line-right-align-edge Charles Gonnaud
2024-04-25 16:36 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865xw51js0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=70485-done@debbugs.gnu.org \
    --cc=charles.gonnaud@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).