unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lin Sun <sunlin7.mail@gmail.com>, Jim Porter <jporterbugs@gmail.com>
Cc: 70691@debbugs.gnu.org
Subject: bug#70691: 30.0.50; [PATCH] Eshell's TERM env varible use eshell-term-name as default
Date: Wed, 01 May 2024 15:15:03 +0300	[thread overview]
Message-ID: <865xvxpw3c.fsf@gnu.org> (raw)
In-Reply-To: <CABCREdq_VzV=MdmzU7Pta+5aoDqK_Z7gxrkYARa8vm9V3Mmh9A@mail.gmail.com> (message from Lin Sun on Wed, 1 May 2024 06:40:25 +0000)

> From: Lin Sun <sunlin7.mail@gmail.com>
> Date: Wed, 1 May 2024 06:40:25 +0000
> 
> Since emacs-29 the Eshell has been enhanced for the ansi-color a lot.
> And the function `eshell-exec-visual` can support the executables with
> colors, eg VIM, tmux...
> I have tested the "/bin/ls --color=tty", "/bin/grep --color=tty" ...
> and other executables in Eshell with "export TERM=eshell-color", they
> all work great.
> 
> So we can safely export eshell's "TERM" with `eshell-term-name` to
> support executables with colors.
> I attached the patch, please help review it. Thanks.

Thanks.

The fact that we can safely do that does not yet mean we _should_ do
it.  In my book, setting TERM is a user preference, more or less.
IOW, this is a change in the default behavior.

Jim, WDYT?





  reply	other threads:[~2024-05-01 12:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-01  6:40 bug#70691: 30.0.50; [PATCH] Eshell's TERM env varible use eshell-term-name as default Lin Sun
2024-05-01 12:15 ` Eli Zaretskii [this message]
2024-05-01 15:51   ` Lin Sun
2024-05-01 18:19   ` Jim Porter
2024-05-01 19:37     ` Lin Sun
2024-05-01 19:49       ` Lin Sun
2024-05-02  6:07       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865xvxpw3c.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=70691@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=sunlin7.mail@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).