unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ke Wu <ellpih@zohomail.jp>
Cc: 71472@debbugs.gnu.org
Subject: bug#71472: [PATCH] Add pty support by using ConPTY on Windows
Date: Tue, 11 Jun 2024 11:42:02 +0300	[thread overview]
Message-ID: <865xuf7twl.fsf@gnu.org> (raw)
In-Reply-To: <19006667d08.6141650b15233.4287906273312116966@zohomail.jp> (message from Ke Wu on Tue, 11 Jun 2024 17:24:58 +0900)

> Date: Tue, 11 Jun 2024 17:24:58 +0900
> From: Ke Wu <ellpih@zohomail.jp>
> Cc: "71472" <71472@debbugs.gnu.org>
> 
> Thank you for your detailed explanation.  The patch itself cannot provide
> a satisfying pty support on Windows.  Its original purpose is to provide
> support to term.el and other packages which setup a terminal emulator
> inside Emacs.  It is not meant to be a replacement of `make-process` on
> Windows, but is used as a supplementary method to patch the broken
> term.el, which has long been an issue for Windows users.

OK, that narrows the applicability and thus the extent of possible
problems.  But still some problems remain: does that work with running
in "M-x term" programs that display fancy/unusual characters?  Did you
try that with Git, for example, showing changes whose authors or text
of the diffs include Unicode characters?  Or what happens if you run
the DIR command of cmd.exe in a directory which has files whose names
aren't supported by the system codepage?  Or what happens if you run a
program whose command-line arguments include characters not supported
by the current system codepage?

IOW, we must understand the limitations of this before we decide
whether this feature is justified.  Installing features with too many
limitations will annoy the users and cause complaints and bug reports.

Thanks.





      reply	other threads:[~2024-06-11  8:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 10:26 bug#71472: [PATCH] Add pty support by using ConPTY on Windows Ke Wu
2024-06-10 15:40 ` Eli Zaretskii
     [not found]   ` <190055cd3c0.5289e49215028.2058921479589116968@zohomail.jp>
2024-06-11  7:27     ` Eli Zaretskii
2024-06-11  8:24       ` Ke Wu
2024-06-11  8:42         ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865xuf7twl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=71472@debbugs.gnu.org \
    --cc=ellpih@zohomail.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).