From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71562: treesit-install-language-grammar fails to install typescript Date: Thu, 20 Jun 2024 14:31:06 +0300 Message-ID: <865xu3onph.fsf@gnu.org> References: <87v82bcrrm.fsf@dod.no> <47399af2-6982-4ce1-ad50-db426624edae@gutov.dev> <86msnmwwbk.fsf@gnu.org> <93d76485-2563-45e3-890d-d5bfc56ff4b7@gutov.dev> <86v829sc18.fsf@gnu.org> <6ac57d91-0aed-4e7d-9022-9697a5a036dd@gutov.dev> <86plscnrhf.fsf@gnu.org> <954cf804-bdf1-4817-9eae-4591aa5f6b53@gutov.dev> <867cejopt8.fsf@gnu.org> <3333f18b-f685-469a-b530-57adb5b6ce4f@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3621"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, sb@dod.no, 71562@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 20 13:32:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKG1Y-0000hL-U9 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Jun 2024 13:32:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKG1J-0003f0-DB; Thu, 20 Jun 2024 07:32:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKG1H-0003cx-0O for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 07:31:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKG1G-0006uC-MA for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 07:31:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sKG1K-0004eC-FQ for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 07:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2024 11:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71562 X-GNU-PR-Package: emacs Original-Received: via spool by 71562-submit@debbugs.gnu.org id=B71562.171888308517801 (code B ref 71562); Thu, 20 Jun 2024 11:32:02 +0000 Original-Received: (at 71562) by debbugs.gnu.org; 20 Jun 2024 11:31:25 +0000 Original-Received: from localhost ([127.0.0.1]:53265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKG0i-0004d1-DT for submit@debbugs.gnu.org; Thu, 20 Jun 2024 07:31:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKG0f-0004aD-E8 for 71562@debbugs.gnu.org; Thu, 20 Jun 2024 07:31:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKG0U-0006qj-Ll; Thu, 20 Jun 2024 07:31:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=X4ysElm34WNDxQkLrEFYpBUoKKPeclR8NuJiwuZAEsU=; b=Nuzc/ZAFtOEK b3d2/+uP4UrlhBIQBjy845v7GQXvvz9xGgYAAdEU92G5Yt7qSXmNl94QNlZuN0xN0DARGotV6Awi0 Dz5IUHB1ngW+NBAayMAIGQ64GZKIDS/4hnxlL3Nj1E7f12PZ6hpCnwHc9rBhsbrVNU5oqZe9fWc5E pip8bRo2kEO22Cll6X+qbhg4WMhlETKJScl7MBoUTEONPVVzAoNAgetzM3422VgPyooX/bVINwbDs Pnc+GBdQW5hjgnFC0N/dKX/LjHhgQ8SfVARpBvkWxncZTWo4cKoh4qk30Tcja07KCV6XNcfciLk1W c9NqLnj4FgWWHATpcb/cBg==; In-Reply-To: <3333f18b-f685-469a-b530-57adb5b6ce4f@gutov.dev> (message from Dmitry Gutov on Thu, 20 Jun 2024 14:18:42 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287550 Archived-At: > Date: Thu, 20 Jun 2024 14:18:42 +0300 > Cc: casouri@gmail.com, sb@dod.no, 71562@debbugs.gnu.org > From: Dmitry Gutov > > On 20/06/2024 13:45, Eli Zaretskii wrote: > >> Date: Thu, 20 Jun 2024 13:28:23 +0300 > >> Cc:casouri@gmail.com,sb@dod.no,71562@debbugs.gnu.org > >> From: Dmitry Gutov > >> > >> On 20/06/2024 07:54, Eli Zaretskii wrote: > >>>> Date: Wed, 19 Jun 2024 22:51:28 +0300 > >>>> Cc:casouri@gmail.com,sb@dod.no,71562@debbugs.gnu.org > >>>> From: Dmitry Gutov > >>>> > >>>> On 16/06/2024 08:16, Eli Zaretskii wrote: > >>>>> I'm saying that we should run the build commands in every subdirectory > >>>>> called 'src' that has parser.c or parser.cc in it. Each shared > >>>>> library thus created should be installed. The name of the library is > >>>>> derived from the parent of the 'src' subdirectory. > >>>> I suppose the downside is when you pass 'tsx' as the language you still > >>>> get nothing. > >>> I don't understand: pass 'tsx' as language to what interface and in > >>> which situation? > >> 1. Bob is a user who wants to edit a tsx file. > >> 2. He tries the tsx-ts-mode and sees the error "TSX grammar not found". > >> 3. He calls 'M-x treesit-install-language-grammar' and inputs 'tsx' as > >> the language. > > And what do you think should happen next? Or where's the problem in > > the above 3 steps? > > Next he presses RET a few times and the installation fails. Why would it fail, if my suggestion is implemented? > If we added two entries to treesit-language-source-alist by default, > OTOH (one for typescript, and another for tsx), then Bob would be able > to install the grammar easily. But then we'd need to maintain a DB of all the "abnormal" repositories (and there a few of them), which is less reliable.