From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71282: 30.0.50; hl-line overlay priority has no affect Date: Sun, 30 Jun 2024 18:34:36 +0300 Message-ID: <865xtqh2b7.fsf@gnu.org> References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1942"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mohkale@kisara.moe, 71282@debbugs.gnu.org, stefankangas@gmail.com To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 30 17:38:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNwdJ-0000FL-0f for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jun 2024 17:38:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNwd4-0005ZL-G8; Sun, 30 Jun 2024 11:38:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNwd1-0005Yg-JY for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 11:38:11 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNwct-0006ZX-Ob for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 11:38:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sNwct-0007kv-8j for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 11:38:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jun 2024 15:38:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71282 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 71282-submit@debbugs.gnu.org id=B71282.171976182529702 (code B ref 71282); Sun, 30 Jun 2024 15:38:03 +0000 Original-Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 15:37:05 +0000 Original-Received: from localhost ([127.0.0.1]:58738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwbq-0007ib-C4 for submit@debbugs.gnu.org; Sun, 30 Jun 2024 11:37:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwbo-0007iN-7C for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 11:36:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNwZc-0004kB-PR; Sun, 30 Jun 2024 11:34:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=MyJeLUyT2eLXoBU8B5O/CmomO4zbCl4KBfi1eiAzX7U=; b=pbB4bdAVpyzUpkGNAz3B LKqc7OL5vntxCtAtdBTsXR6UeyLw0WUiYoQUFS8z7nrMjMo0SKR45qAjFF0odCw7VhfJdlAfkXn5l MLxOvxI97F26uRSiMu9yp2gShBsawmolo3GnEKVZTQmH8EAssqPfQja4JEajWViwCXjbRWWe8Eoni k+5GGeI/DpDnVvvstiKs4s7GVkGCC1nR5vshVxh7J92xgtaRwUSoqtmxLq/XAzq6jssD7SfbvXdwp Y1DDnHWoz9C45MS77NpFqPJlrsItb/ZB9+ZksVkrN6L5C1cv4EJq5xrVwPRiU6mTPHxOwmsuD3YsJ iRu4X8pWlVNW/A==; In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Sun, 30 Jun 2024 16:12:55 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288203 Archived-At: > From: João Távora > Date: Sun, 30 Jun 2024 16:12:55 +0100 > Cc: Mohsin Kaleem , stefankangas@gmail.com, 71282@debbugs.gnu.org > > On Sun, Jun 30, 2024 at 3:47 PM Eli Zaretskii wrote: > > > > > From: Mohsin Kaleem > > > Cc: stefankangas@gmail.com, 71282@debbugs.gnu.org > > > Date: Sun, 30 Jun 2024 14:41:13 +0100 > > > > > > Eli Zaretskii writes: > > > I don't think it's a "problem". Overlay strings have their own faces, > > and those override the faces of buffer text. > > If I understand the scenario correctly, I agree with Moshin that this > is a more general issue. There should be some way for overlays > used by a package X to easily combine with an existing an > existing background color, even if that background color is mandated > by some hl-current-line extension Y. This mechanism shouldn't rely > on making X aware of Y. The mechanism exists: find the face of the buffer text, and use it (or some of its attributes, like background color) in determining the face of the overlay string. In some cases, Emacs does this merging automatically, but this is not one of those cases. (I think in this case if hl-line uses text properties instead of overlays, this will happen automatically. But I didn't try that, and I might be missing something in this complex issue.) > Maybe if the implementation of Y were moved to C display core, like > display-line-numbers-mode. Or maybe not, I haven't looked into it > (and I don't plan to, sorry). That's unrelated. The order of merging face information is documented in the ELisp manual, and changing it is out of the question, because it worked like that for many years, and any change in it is bound to break something out there.