From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73635: dired-do-query-replace-regexp should check if files are selected first Date: Sat, 19 Oct 2024 10:02:09 +0300 Message-ID: <865xpomv7y.fsf@gnu.org> References: <87frpbb4cn.3.fsf@jidanni.org> <87v7y7b2mn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29651"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73635-done@debbugs.gnu.org, jidanni@jidanni.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 19 09:02:55 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t23UE-0007To-RF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Oct 2024 09:02:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t23U1-0001vx-D7; Sat, 19 Oct 2024 03:02:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t23Tz-0001vY-3S for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 03:02:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t23Ty-0000zF-RS for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 03:02:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=2EUopkGf3XhHJvP4j9zkKnt6pRyfaDlLkbmezsQcoU4=; b=Xxom3M555ENNsKW9hZyUGRFSVyC5jabj07cTLpBHJUuwly8ADXF8AEisLTAheDFddzZ9eWOS/uiUNlh8nA0179PzhCL+dh4VWW5PE/1ut3p7G9DX0W2t5kOgIoHWRM1s+H9Wo3Ll5Rtod9Phc4Vdi6LjilUrL2GK8cDvLPgi/rn3NprE+G+eofZChLwnUkXuVMSMT+BNkFs6Fujn/g2/OvS5duuiU1H2jytRPPcCBCQZgaGTa6BS4cOQWj+s4FeUXZEzNxB/29RTsA1BbMpsQyJrD4P1pTyRsjmzfZ1myxAv498BPi7wafvB1xK8VkLy/BQqbvey+DQfmgq6lkf3kA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t23UM-0006zC-3Z for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 03:03:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Oct 2024 07:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73635 X-GNU-PR-Package: emacs Mail-Followup-To: 73635@debbugs.gnu.org, eliz@gnu.org, jidanni@jidanni.org Original-Received: via spool by 73635-done@debbugs.gnu.org id=D73635.172932136426825 (code D ref 73635); Sat, 19 Oct 2024 07:03:01 +0000 Original-Received: (at 73635-done) by debbugs.gnu.org; 19 Oct 2024 07:02:44 +0000 Original-Received: from localhost ([127.0.0.1]:41078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t23U3-0006ya-Sf for submit@debbugs.gnu.org; Sat, 19 Oct 2024 03:02:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t23U1-0006yM-PT for 73635-done@debbugs.gnu.org; Sat, 19 Oct 2024 03:02:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t23TY-0000y6-Uq; Sat, 19 Oct 2024 03:02:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2EUopkGf3XhHJvP4j9zkKnt6pRyfaDlLkbmezsQcoU4=; b=XdS93yocqS1ajei+vBxi uvqorOqqZia56Hz1aIMf9uW5HNokZUrh/LA/7di8TQvDWPhhCI4UsF58Gzc14VlQ+2xN3twq4i0d9 DvpxzOTjkueXkm43wURZIrylEQIaeXrkYUgMmYusP68zPze3xCIvc/EJejqJjU1Ie1TvgIzifdNYO vtx/v3ZwFZnFUbpNjzYPAMSvINag2EJOLarmWIyz1OYkidmAPdBX361qofu5zQ7RvLL9PlqlT7uHk xrnzDS6fnwzw015nTpkARUgopT+BtuTHRpt+VxgBl+4mgWFtITbYyuFeG0LuAZPQCgr/vaSr6mBBl qT31xeBJa0n2nw==; In-Reply-To: <87v7y7b2mn.fsf@gmail.com> (message from Visuwesh on Sat, 05 Oct 2024 09:52:08 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293837 Archived-At: > Cc: 73635@debbugs.gnu.org > From: Visuwesh > Date: Sat, 05 Oct 2024 09:52:08 +0530 > > [சனி அக்டோபர் 05, 2024] Dan Jacobson wrote: > > > dired-do-query-replace-regexp > > asks for the replace from value, > > then asks for the replace to value, > > and only then finally checks if any files are selected in the first > > place. > > > > It needs to check first. > > > > E.g., yes there were files selected, but we just did a first run, and > > are no longer looking at the dired buffer. We need to go back to the > > dired buffer first. Fine. But at least let the user know before they > > bother entering the from and to values. > > It uses the filename under point if there are no marked files like all > dired commands. Right, and so I think there's no bug here to fix, and I'm therefore closing it.