From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Sat, 07 Dec 2024 17:02:32 +0200 Message-ID: <865xnviliv.fsf@gnu.org> References: <86wmgfzhgc.fsf@gnu.org> <86zflay7hh.fsf@gnu.org> <86jzcey3cu.fsf@gnu.org> <8634j1n9nx.fsf@gnu.org> <86ldwrkeiy.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19184"; mail-complaints-to="usenet@ciao.gmane.io" Cc: trevor.m.murphy@gmail.com, me@eshelyaron.com, monnier@iro.umontreal.ca, 73862@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 07 16:03:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJwL9-0004o8-3z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Dec 2024 16:03:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJwKo-000783-Jo; Sat, 07 Dec 2024 10:03:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJwKl-00077n-8K for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 10:03:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJwKk-0006YB-Va for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 10:03:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=iyKoefbkF7bfukIfMjeT/B5pXHkZWpIyXF0g9jqyb5U=; b=SQemcN6J8N1dYGZRhzwho9Xxco1UwrGA+umGdxg7ona1nfJ1sCPYDHMYeLrGpPDfqVgLehLPj2uNEu00l2F3mduSHbXKitsA8dMUx6So11HnrI/fXjJUF5YuveEBHRpORItIDzD++IuywrsHBT4CLE4P87zAF53yujcp2d1Ha0BTDMhcRyCiH4bDSWFcwhCPnx85JZKTBldKrDIK5oLTonIPNXXQ4u1+lbux4Bj3HNLs5ZoRY8DymUDXH+IOzMrKVH+wQ85kzVoARUob3vgZM0RRQxzIeXhvwFwybtf2MPfFBnVPtRIH7s5N1bFMJYx+85v/a1b3E3jHUPq2ARR9eg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJwKk-00026Q-EN for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 10:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Dec 2024 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.17335837658052 (code B ref 73862); Sat, 07 Dec 2024 15:03:02 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 7 Dec 2024 15:02:45 +0000 Original-Received: from localhost ([127.0.0.1]:48183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJwKS-00025o-KT for submit@debbugs.gnu.org; Sat, 07 Dec 2024 10:02:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJwKO-00025X-Po for 73862@debbugs.gnu.org; Sat, 07 Dec 2024 10:02:42 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJwKJ-0006VG-40; Sat, 07 Dec 2024 10:02:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iyKoefbkF7bfukIfMjeT/B5pXHkZWpIyXF0g9jqyb5U=; b=eh5caTo3Xyud xcgbEf/+F8vfe92plQvlKL93B0t50sgnTXXGd8qXx5wXXOrksmFEb9nq1D7Vumt1jlv6a2+qupzH8 89vbmgzpNsTDFWCugw4evsy1OfF6+ukWuRomK0+7WS7p6f+LqjZqmorpz32nWFGcY+7uwY94f6Mtf fucMADocEi74fZZUr2KXvnHhjMVxEPGzaIoy7nW+nv7e777RpMVoZP62CC0349hPNcpdu7ekeNfWo 0R0whchENycphm2iijtnlK9nYwmOWa/se498QUKe01OX535tg2UWo99SV2oMD39lH0d5P2uXJr9I7 OGJ0wsRatU12Y33DXX40UQ==; In-Reply-To: (message from Aaron Jensen on Sat, 7 Dec 2024 07:28:33 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296575 Archived-At: > From: Aaron Jensen > Date: Sat, 7 Dec 2024 07:28:33 -0600 > Cc: Stefan Monnier , trevor.m.murphy@gmail.com, me@eshelyaron.com, > 73862@debbugs.gnu.org > > On Sat, Dec 07, 2024 at 1:50 AM, Eli Zaretskii wrote: > > > If we do prefer to support remapping mode-line and header-line faces, then > > I can suggest the semi-kludgey "fix" below. Is this better than what we > > have now? > > Does this patch make it so that remaps are considered for header-line even > if header-line-active no longer inherits from header-line? It shouldn't. If you apply it and see something like that, it should be considered a bug somewhere (but I would be very surprised if it did happen). All this change does it give the code the chance to account for remapping of header-line-active if header-line was remapped. But if the latter doesn't inherit from the former, that chance will not produce anything that depends on header-line's remapping. > The more I think about this, the less > inclined I'd be to play special case whack-a-mole with it and the more I'd > be inclined to either "live with it" or figure out a way to disable > remapping entirely in certain rendering contexts. Disabling remapping entirely is not feasible, since too many places already account for remapping. > Tab bar mode is another one that comes to mind that probably > shouldn't use remaps at all when rendering. Why not?