From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74902: 31.0.50; Segfault when deleting frames Date: Sat, 04 Jan 2025 14:02:28 +0200 Message-ID: <865xmueqi3.fsf@gnu.org> References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> <87y0zveqv0.fsf@stebalien.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16403"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, 74902@debbugs.gnu.org To: Steven Allen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 04 13:03:21 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tU2sC-00045x-8U for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Jan 2025 13:03:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU2rw-0004Vv-Bn; Sat, 04 Jan 2025 07:03:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU2ru-0004VS-Qn for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 07:03:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tU2ru-0001wO-Hv for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 07:03:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=JHfzwQ1UqYkrnZQRUWCLcjN0x0j8tBiqO8KMoBVJzMQ=; b=hXW+aB6r4dBqPoM3sO6Q0kaByTfn64D+40M0SZGFl7BA5Zw2LquA4Cjj98a1ZiyVMOyLtNihgmYmmkvDNEqWn5/h+ATUuCqLJpiBd3CcRIhPhhV713THrw91SnPs0fLsi3Vp+739RDXwNwqqE+Xxmxro5NJUsffWRUaD1Zkg7pFGkH3c7x/LfjJLUWJk6ctdb3sB0qZxEVbZ9m6zroWEJ6iN7ucmiQgnbvQa9tNJjInUZKvwWDGBrV4ZmCR6njz6OCBzks5du6ohS6EZ16uiBD4Ds560ZOBPWv0I0AIkNMqutfclY8i4d9SnhbZjipQ9r3Qj5WAl706S1QjAia0EfQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tU2ru-00047F-CC for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 07:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 12:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74902 X-GNU-PR-Package: emacs Original-Received: via spool by 74902-submit@debbugs.gnu.org id=B74902.173599215915780 (code B ref 74902); Sat, 04 Jan 2025 12:03:02 +0000 Original-Received: (at 74902) by debbugs.gnu.org; 4 Jan 2025 12:02:39 +0000 Original-Received: from localhost ([127.0.0.1]:53738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU2rX-00046S-DO for submit@debbugs.gnu.org; Sat, 04 Jan 2025 07:02:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50606) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU2rV-00046E-An for 74902@debbugs.gnu.org; Sat, 04 Jan 2025 07:02:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU2rP-0001uG-Oa; Sat, 04 Jan 2025 07:02:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JHfzwQ1UqYkrnZQRUWCLcjN0x0j8tBiqO8KMoBVJzMQ=; b=C5vKGW+Ldl6d tGAQyOlWEsYQ6zN7f13Z47CgATMeqtdAd8nIl0qyZjNnxOeaVvunsTI07DzRvfzkYk9nqYg5H/Y0q GUxOfhAZaOnVPVYB/5wdbRGIuHyVBlLhCJNQDdMXnn9i966bpTbp68L0RRB5GcnfPfVN0KJr+JDep ddSa30LOqLFNMhPsfx0qTH5FAeMbKdw2MFajnejkGciOHesDiDoiHccIx9DMlt0ek5aiycLa+ehrk fljlwBtLLbPtM+45gHK/MAp8e83FxjwHDmgCIEqV22mXG5oYuX+cBOOmYpzwmt0KfDOXKQ/rhCEIp ff5J/iK0WkCiOSC2H6D8Qg==; In-Reply-To: <87y0zveqv0.fsf@stebalien.com> (message from Steven Allen on Tue, 31 Dec 2024 08:53:23 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298382 Archived-At: > From: Steven Allen > Cc: 74902@debbugs.gnu.org > Date: Tue, 31 Dec 2024 08:53:23 -0800 > > > Robert Pluim writes: > > If you do find a reproducer, then based on the trace above I think the > > following should fix it: > > > > diff --git a/src/frame.c b/src/frame.c > > index f6053fca3ef..ff9e1d24ea1 100644 > > --- a/src/frame.c > > +++ b/src/frame.c > > @@ -2281,7 +2281,9 @@ delete_frame (Lisp_Object frame, Lisp_Object force) > > delete_all_child_windows (f->root_window); > > fset_root_window (f, Qnil); > > > > + block_input(); > > Vframe_list = Fdelq (frame, Vframe_list); > > + unblock_input(); > > SET_FRAME_VISIBLE (f, 0); > > > > /* Allow the vector of menu bar contents to be freed in the next > > >From what I can tell (my reproducer isn't 100% effective), this does > indeed fix the issue. Thanks! Robert, please install, and thanks.