From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Joe Wells Newsgroups: gmane.emacs.bugs Subject: bug#457: wdired and auto-revert-mode Date: Mon, 04 Aug 2008 14:33:00 +0100 Message-ID: <864p60vrar.fsf@macs.hw.ac.uk> References: <86abftuiy5.fsf@macs.hw.ac.uk> <4896F015.8080008@gmx.at> Reply-To: Joe Wells , 457@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1217858667 11521 80.91.229.12 (4 Aug 2008 14:04:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Aug 2008 14:04:27 +0000 (UTC) Cc: michael_heerdegen@web.de, 457@emacsbugs.donarmstrong.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 04 16:05:16 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KQ0gI-0006le-LP for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Aug 2008 16:05:03 +0200 Original-Received: from localhost ([127.0.0.1]:50656 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQ0fN-0001nL-Iq for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Aug 2008 10:04:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQ0bN-00050b-CX for bug-gnu-emacs@gnu.org; Mon, 04 Aug 2008 09:59:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQ0bH-0004rs-Gb for bug-gnu-emacs@gnu.org; Mon, 04 Aug 2008 09:59:53 -0400 Original-Received: from [199.232.76.173] (port=34630 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQ0bH-0004ri-Bn for bug-gnu-emacs@gnu.org; Mon, 04 Aug 2008 09:59:51 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:39386) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KQ0bH-0001A9-Fp for bug-gnu-emacs@gnu.org; Mon, 04 Aug 2008 09:59:51 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQ0T5-0005I2-OA for bug-gnu-emacs@gnu.org; Mon, 04 Aug 2008 09:51:24 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m74DlMot006821; Mon, 4 Aug 2008 06:47:22 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m74De5Wg004255; Mon, 4 Aug 2008 06:40:05 -0700 X-Loop: don@donarmstrong.com Resent-From: Joe Wells Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 04 Aug 2008 13:40:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 457 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 457-submit@emacsbugs.donarmstrong.com id=B457.12178567972450 (code B ref 457); Mon, 04 Aug 2008 13:40:05 +0000 Original-Received: (at 457) by emacsbugs.donarmstrong.com; 4 Aug 2008 13:33:17 +0000 Original-Received: from mail-r.hw.ac.uk (mail-r.hw.ac.uk [137.195.101.215]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m74DXDlg002444 for <457@emacsbugs.donarmstrong.com>; Mon, 4 Aug 2008 06:33:14 -0700 Original-Received: from izanami.macs.hw.ac.uk ([137.195.13.6]) by mail-r.hw.ac.uk with esmtp (Exim 4.54) id 1KQ0BJ-0008Ds-MP; Mon, 04 Aug 2008 14:33:02 +0100 Original-Received: from lxultra1.macs.hw.ac.uk ([137.195.27.173]:54024 helo=127.0.0.1) by izanami.macs.hw.ac.uk with smtp (Exim 4.51) id 1KQ0BJ-0000zq-DD; Mon, 04 Aug 2008 14:33:01 +0100 Original-Received: (nullmailer pid 13915 invoked by uid 1001); Mon, 04 Aug 2008 13:33:00 -0000 In-Reply-To: <4896F015.8080008@gmx.at> (martin rudalics's message of "Mon\, 04 Aug 2008 14\:03\:33 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-HW-MailScanner-Information: Please contact the HW Helpdesk for more information X-HW-MailScanner: Found to be clean X-HW-MailScanner-SpamCheck: not spam, SpamAssassin (score=-4.399, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -2.60) X-HW-MailScanner-From: jbw@macs.hw.ac.uk X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Resent-Date: Mon, 04 Aug 2008 09:59:53 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19008 Archived-At: martin rudalics writes: >> The correct way to handle this is to mark the buffer as modified >> during the period for which it should not be auto-reverted. > > No. `buffer-modified-p' is busy telling whether the user has modified > the buffer with `wdired'. It's used many times in wdired.el. Just make sure to leave the buffer marked as modified as long as there are changes that should not be lost by reverting. If you do that, then auto-revert-mode will not lose changes. Is something in wdired doing (set-buffer-modified-p nil) *before* the changes have been recorded? -- Joe >> The >> function auto-revert-handler refuses to do anything with buffers that >> are marked as modified. The first thing auto-revert-handler does is >> check the condition (buffer-modified-p). > > martin -- Heriot-Watt University is a Scottish charity registered under charity number SC000278.