From: Joe Wells <jbw@macs.hw.ac.uk>
To: martin rudalics <rudalics@gmx.at>
Cc: michael_heerdegen@web.de, 457@emacsbugs.donarmstrong.com
Subject: bug#457: wdired and auto-revert-mode
Date: Mon, 04 Aug 2008 14:33:00 +0100 [thread overview]
Message-ID: <864p60vrar.fsf@macs.hw.ac.uk> (raw)
In-Reply-To: <4896F015.8080008@gmx.at> (martin rudalics's message of "Mon\, 04 Aug 2008 14\:03\:33 +0200")
martin rudalics <rudalics@gmx.at> writes:
>> The correct way to handle this is to mark the buffer as modified
>> during the period for which it should not be auto-reverted.
>
> No. `buffer-modified-p' is busy telling whether the user has modified
> the buffer with `wdired'. It's used many times in wdired.el.
Just make sure to leave the buffer marked as modified as long as there
are changes that should not be lost by reverting. If you do that,
then auto-revert-mode will not lose changes.
Is something in wdired doing (set-buffer-modified-p nil) *before* the
changes have been recorded?
--
Joe
>> The
>> function auto-revert-handler refuses to do anything with buffers that
>> are marked as modified. The first thing auto-revert-handler does is
>> check the condition (buffer-modified-p).
>
> martin
--
Heriot-Watt University is a Scottish charity
registered under charity number SC000278.
next prev parent reply other threads:[~2008-08-04 13:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.15789.1217765249.18990.bug-gnu-emacs@gnu.org>
2008-08-04 11:18 ` bug#457: wdired and auto-revert-mode Joe Wells
2008-08-04 12:03 ` martin rudalics
2008-08-04 13:33 ` Joe Wells [this message]
2008-08-04 16:08 ` martin rudalics
2008-08-04 18:38 ` Joe Wells
2008-08-04 21:24 ` martin rudalics
[not found] ` <mailman.15844.1217875649.18990.bug-gnu-emacs@gnu.org>
2008-08-11 16:28 ` Michael Heerdegen
2008-08-11 17:30 ` Joe Wells
2008-08-13 16:22 ` Michael Heerdegen
2008-08-21 8:04 ` martin rudalics
2008-08-03 11:45 martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864p60vrar.fsf@macs.hw.ac.uk \
--to=jbw@macs.hw.ac.uk \
--cc=457@emacsbugs.donarmstrong.com \
--cc=michael_heerdegen@web.de \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).