From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52023: [External] : Re: bug#52023: 27.2; Enhancement: `this-command-invocation-(buffer|window)' Date: Mon, 22 Nov 2021 19:46:37 +0200 Organization: LINKOV.NET Message-ID: <864k846q2q.fsf@mail.linkov.net> References: <867dd1mhn7.fsf@mail.linkov.net> <86pmqstxxs.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21580"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: "52023@debbugs.gnu.org" <52023@debbugs.gnu.org> To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 22 18:50:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpDSD-0005Pm-N3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Nov 2021 18:50:09 +0100 Original-Received: from localhost ([::1]:35702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpDSC-0000CZ-9S for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Nov 2021 12:50:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpDS6-0000CE-Ol for bug-gnu-emacs@gnu.org; Mon, 22 Nov 2021 12:50:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpDS6-0001sD-F7 for bug-gnu-emacs@gnu.org; Mon, 22 Nov 2021 12:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpDS6-0007Vl-CW for bug-gnu-emacs@gnu.org; Mon, 22 Nov 2021 12:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Nov 2021 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52023 X-GNU-PR-Package: emacs Original-Received: via spool by 52023-submit@debbugs.gnu.org id=B52023.163760334828800 (code B ref 52023); Mon, 22 Nov 2021 17:50:02 +0000 Original-Received: (at 52023) by debbugs.gnu.org; 22 Nov 2021 17:49:08 +0000 Original-Received: from localhost ([127.0.0.1]:49057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpDRE-0007UR-HS for submit@debbugs.gnu.org; Mon, 22 Nov 2021 12:49:08 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:59135) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpDRC-0007Tw-C3 for 52023@debbugs.gnu.org; Mon, 22 Nov 2021 12:49:06 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 189D2240006; Mon, 22 Nov 2021 17:48:55 +0000 (UTC) In-Reply-To: (Drew Adams's message of "Mon, 22 Nov 2021 15:17:54 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220629 Archived-At: >> But in any case you can use `pre-command-hook' to store >> the original buffer and window. > > Please the bug report. It includes this: A verb is missing. I assume you meant: "Please close the bug report"? > Currently, to get this information a workaround > would be to use a `pre-command-hook' function > that sets variables, and then to test those variables. Indeed, `pre-command-hook' could be used to set these variables, and other possible variables. There are much worse problems while using window-configuration-change-hook. When this hook is fired, it doesn't provide the previous window-configuration as its argument, thus requiring remembering the old window-configuration in `pre-command-hook'. So every `pre-command-hook' calls `current-window-configuration' that is huge performance overhead. This is worse than remembering a variable in `pre-command-hook', and still no one complains about this.