From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52293: 29.0.50; [PATCH] Prevent further cases of duplicated separators in context menus Date: Sun, 05 Dec 2021 11:39:50 +0200 Organization: LINKOV.NET Message-ID: <864k7n9xt5.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13369"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 52293@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 05 11:06:36 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtoPk-0003LD-LI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Dec 2021 11:06:36 +0100 Original-Received: from localhost ([::1]:52324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtoPj-0005Jl-GZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Dec 2021 05:06:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtoOM-0003cD-Lz for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 05:05:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44882) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtoOH-0002pk-05 for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 05:05:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mtoOG-0004yq-P6 for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 05:05:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2021 10:05:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163869869119056 (code B ref 52293); Sun, 05 Dec 2021 10:05:04 +0000 Original-Received: (at 52293) by debbugs.gnu.org; 5 Dec 2021 10:04:51 +0000 Original-Received: from localhost ([127.0.0.1]:56422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtoO2-0004xG-M0 for submit@debbugs.gnu.org; Sun, 05 Dec 2021 05:04:50 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:38047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtoO1-0004w0-3D for 52293@debbugs.gnu.org; Sun, 05 Dec 2021 05:04:49 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 6BB97240006; Sun, 5 Dec 2021 10:04:40 +0000 (UTC) In-Reply-To: (Jim Porter's message of "Sat, 4 Dec 2021 21:58:24 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221606 Archived-At: > Attached is a patch to fix this based on the discussion in bug#52237. Thanks for the patch. > One slightly odd thing is that for context menu functions that put their items > at the top, they place their separator *below* the items. Other functions > place the separator *above* the items. There is some logic in this: when the menu doesn't contain a separator at the top, then it is necessary to add a separator below the added items, e.g. by modifying such a menu: - existing menu item 1 - existing menu item 2 to - new item 1 - new item 2 - new separator - existing menu item 1 - existing menu item 2