From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Date: Wed, 21 Sep 2022 21:52:28 +0300 Organization: LINKOV.NET Message-ID: <864jx0o903.fsf@mail.linkov.net> References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17274"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 57807@debbugs.gnu.org To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 21 21:03:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ob50B-0004OB-Pn for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 21:03:19 +0200 Original-Received: from localhost ([::1]:58706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ob50A-0007OG-My for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 15:03:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ob4w3-0004Hb-ER for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 14:59:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36179) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ob4w2-0002Ry-Tc for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 14:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ob4w2-00020z-Bk for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 14:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2022 18:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs Original-Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.16637866857681 (code B ref 57807); Wed, 21 Sep 2022 18:59:02 +0000 Original-Received: (at 57807) by debbugs.gnu.org; 21 Sep 2022 18:58:05 +0000 Original-Received: from localhost ([127.0.0.1]:35257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ob4v6-0001zo-UW for submit@debbugs.gnu.org; Wed, 21 Sep 2022 14:58:05 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:59285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ob4v6-0001zL-4T for 57807@debbugs.gnu.org; Wed, 21 Sep 2022 14:58:04 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id AD438FF809; Wed, 21 Sep 2022 18:57:56 +0000 (UTC) In-Reply-To: <8735clu05s.fsf@melete.silentflame.com> (Sean Whitton's message of "Tue, 20 Sep 2022 15:54:39 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243374 Archived-At: > I've done something about all these in the attached. What do you think? Adding vc-pre-command-functions as a counterpart of the existing vc-post-command-functions is a nice solution. I tested everything, and there are no more problems. Thanks for implementing this feature. After you will push it, it would be good also to try to generalize it to other vc commands. The problem is that some commands already use C-u for other purposes, such as 'C-u C-x v L' asks for a limit. What would be a possible way to set vc-want-edit-command-p without using a prefix arg? Maybe to add a new command that will only set vc-want-edit-command-p for the next vc command, and bind it to e.g. 'C-x v c'. Then 'C-x v c C-x v L' will allow editing the root log command.