From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70820: [PATCH] Editable grep buffers Date: Wed, 08 May 2024 16:49:41 +0300 Message-ID: <864jb89zwq.fsf@gnu.org> References: <87seytlhcq.fsf@gmail.com> <86pltxa40q.fsf@gnu.org> <87jzk5kmwk.fsf@gmail.com> <86ikzoa51h.fsf@gnu.org> <878r0klcp1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34156"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70820@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 08 15:50:54 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s4hh7-0008p0-OU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 May 2024 15:50:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4hgt-0007wI-S1; Wed, 08 May 2024 09:50:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4hgr-0007vB-RY for bug-gnu-emacs@gnu.org; Wed, 08 May 2024 09:50:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s4hgr-0005b2-DI for bug-gnu-emacs@gnu.org; Wed, 08 May 2024 09:50:37 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s4hhG-0003lZ-HA for bug-gnu-emacs@gnu.org; Wed, 08 May 2024 09:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2024 13:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70820 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70820-submit@debbugs.gnu.org id=B70820.171517621914466 (code B ref 70820); Wed, 08 May 2024 13:51:02 +0000 Original-Received: (at 70820) by debbugs.gnu.org; 8 May 2024 13:50:19 +0000 Original-Received: from localhost ([127.0.0.1]:49035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4hgZ-0003lE-Ea for submit@debbugs.gnu.org; Wed, 08 May 2024 09:50:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4hgV-0003l8-SI for 70820@debbugs.gnu.org; Wed, 08 May 2024 09:50:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4hg0-0005EL-Pe; Wed, 08 May 2024 09:49:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xDssSeiJ7NPXswY5f7mjJu9eiuL2FIxyw6phbqxCo7I=; b=kK3DBXOpTkVh2MLib+yg BWjN8aTrY855r07rjnSbwN9Ij5G/Ui4IjPgjL21SDaqnJKExEe+IeTeB6mzqsuKMGXhuvYPn4Y/yF yatTSG5Pwf3Hqaxp24Lmb8efqXEp2lSXsw7tII7/TrEw1bAljBYXF9aWrJMLgvHxFulBFcV/YldGA bUWyr0LLpYeEmhoos03AfeK62SAKpv5ouWO+6bqtngK2pWlfKZrVH0XVNVt6zVuNAE2l2df/r/50Y K/pbM4jTm5UIZrkrCAvx3gUqhID2qJaE1PL59nvtWw+5RI2B4SxLcs99sXjoObk7dmvsKb7+c6QEK i4tvHw6RqNfOXw==; In-Reply-To: <878r0klcp1.fsf@gmail.com> (message from Visuwesh on Wed, 08 May 2024 17:48:02 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284678 Archived-At: > From: Visuwesh > Cc: 70820@debbugs.gnu.org > Date: Wed, 08 May 2024 17:48:02 +0530 > > [புதன் மே 08, 2024] Eli Zaretskii wrote: > > > I think having similar features that work very differently is not a > > good thing for Emacs. So I urge you to reconsider your decisions and > > make this more like occur-edit-mode. In particular, I don't > > understand the difficulty with using the markers and what does it have > > to do with the ability of having many Grep buffers. > > It is not having many Grep buffers but visiting the "original" files > unnecessarily that tends to be annoying. Why is this annoying? > > I don't think I understand this difficulty, either: with > > occur-edit-mode it is solved by making occur-edit-mode be derived from > > occur-mode. Couldn't you do the same with your mode? > > No because occur-mode makes occur-revert-arguments permanent-local so > `g' survives the major-mode changes. > > For revert-buffer alone, compilation-arguments needs to be marked > permanent-local. As it is a part of compile.el, I am not sure if > marking it as such is safe. This is why I think having a minor-mode is > better. It sounds like a minor issue which shouldn't have such grave consequences. Why do you think making compilation-arguments permanent-local would be a problem? We could ask people who frequently contribute to compile.e land grep.el if they see any problem with doing that.