From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68054: [PATCH] Add tree-sitter indent rule for lexical decls in js/typescript Date: Sat, 18 May 2024 11:29:57 +0300 Message-ID: <864javfrp6.fsf@gnu.org> References: <797AC075-B0C8-4269-B8E3-A1F2C69FA955@gmail.com> <14DD6D3A-B9F5-4E5F-B85B-0A8DF6961723@gmail.com> <5fd5b131-962a-489d-a674-0e199cdfff25@gutov.dev> <49231C5D-E89E-4AA3-AB02-51340994EA20@gmail.com> <661fc11d-6da8-4fe5-a900-80ed1b41823a@gutov.dev> <3cf27c4d-d5ee-423c-a0d2-cfae297d36ae@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27499"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, casouri@gmail.com, 68054@debbugs.gnu.org To: Noah Peart Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 18 10:31:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s8FTD-0006wz-UP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 May 2024 10:31:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s8FT3-000673-5x; Sat, 18 May 2024 04:31:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8FT1-00066h-E1 for bug-gnu-emacs@gnu.org; Sat, 18 May 2024 04:30:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s8FT1-0002xy-5Z for bug-gnu-emacs@gnu.org; Sat, 18 May 2024 04:30:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s8FT4-0007WY-E2 for bug-gnu-emacs@gnu.org; Sat, 18 May 2024 04:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 May 2024 08:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68054 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68054-submit@debbugs.gnu.org id=B68054.171602101128910 (code B ref 68054); Sat, 18 May 2024 08:31:02 +0000 Original-Received: (at 68054) by debbugs.gnu.org; 18 May 2024 08:30:11 +0000 Original-Received: from localhost ([127.0.0.1]:60279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8FSF-0007WE-10 for submit@debbugs.gnu.org; Sat, 18 May 2024 04:30:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8FSD-0007Ux-TO for 68054@debbugs.gnu.org; Sat, 18 May 2024 04:30:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8FS4-0002TA-5I; Sat, 18 May 2024 04:30:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Pt2cnUqTGiebtHIQdzvuBLWzQSaGuTwv7iq0denQlWs=; b=i7xuX5DCh+zC tZKv7hCe0ExMNK8lPzvxROjEChQMzZtxbe/7deMeUT0cuxLcGTWT2JWD/Bo6x8/XkDnQaV/pO4hvy diw/It1GUjYV8D6eYU3WD0TJF03IzMBw58npAjIF0nKip04R138RK8jr3ujPEkMLnz/60ufTIKwL1 YZg5plj1obYxjxi+XezsjR8US9PZWAZSMYFzx4//w9CsGsmPRGF3vT6i27f7e7O6JhLJEN0E0RhIO UpWamkRRQyN0G5CqzYhtXCgjTTodhSVhrx/ZMrJ8BDwTREWNzDrp/3kO0dU1P9EiYitWdaykt/ldI LyTS6AvbOhzAp64wO2qywA==; In-Reply-To: (message from Noah Peart on Thu, 2 May 2024 06:38:57 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285290 Archived-At: > Cc: Yuan Fu , 68054@debbugs.gnu.org > From: Noah Peart > Date: Thu, 2 May 2024 06:38:57 -0700 > > > js-ts-mode now has the exact same indentation > > I'm not sure what you meant by this - did you mean js-ts-mode has > the same indentation for non-multivar declarations as the examples > shown above? js-ts-mode is still missing indentation rules for multiple decl statements. > The patch would work for js-ts-mode as well, but I didn't want to copy the > code between the files. > > So much of the grammar is shared between js-ts-mode and > typescript-ts-mode, it might be worth combining - neovim uses an ecma grammar > from which they both inherit. Not sure what is the conclusion here. Are there any objections to installing Noah's last patch?