From: Eli Zaretskii <eliz@gnu.org>
To: "Rudolf Adamkovič" <rudolf@adamkovic.org>
Cc: luangruo@yahoo.com, 71638@debbugs.gnu.org
Subject: bug#71638: 30.0.50; Compilation warnings
Date: Thu, 20 Jun 2024 18:48:16 +0300 [thread overview]
Message-ID: <864j9nobsv.fsf@gnu.org> (raw)
In-Reply-To: <m2tthnkarg.fsf@adamkovic.org> (message from Rudolf Adamkovič on Thu, 20 Jun 2024 15:24:19 +0200)
> From: Rudolf Adamkovič <rudolf@adamkovic.org>
> Cc: Po Lu <luangruo@yahoo.com>, 71638@debbugs.gnu.org
> Date: Thu, 20 Jun 2024 15:24:19 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Thanks, I tried to fix that now on master.
>
> All warnings are gone *except* this one:
>
> xwidget.c:492:17: warning: variable 'f' set but not used
> struct frame *f = NULL;
> ^
Sorry, this one you will have to live with: the setting of 'f' is part
of checking the validity of the function's arguments, so it must be
left alone.
> Also, CC'in Po Lu, as after his 'cebca072c33', I *cannot build*:
>
> CC nsxwidget.o
> nsfns.m:1320:3: error: use of undeclared identifier 'image_cache_refcount'
> image_cache_refcount =
> ^
> nsfns.m:3025:3: error: use of undeclared identifier 'image_cache_refcount'
> image_cache_refcount =
> ^
> 2 errors generated.
Please try again, I think this was fixed meanwhile.
> > In the future, please try to fix this on your system, because that's
> > the best place to make sure the changes indeed eliminate the warnings.
>
> Honestly, I did not want to risk wasting more of your time that way.
It's the other way around, actually.
next prev parent reply other threads:[~2024-06-20 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 21:50 bug#71638: 30.0.50; Compilation warnings Rudolf Adamkovič
2024-06-19 11:31 ` Eli Zaretskii
2024-06-20 13:24 ` Rudolf Adamkovič
2024-06-20 15:48 ` Eli Zaretskii [this message]
2024-06-30 5:36 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864j9nobsv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71638@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
--cc=rudolf@adamkovic.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).