From: Eli Zaretskii <eliz@gnu.org>
To: bkhl@elektrubadur.se
Cc: acorallo@gnu.org, 71499@debbugs.gnu.org, stefankangas@gmail.com
Subject: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline
Date: Thu, 27 Jun 2024 10:37:24 +0300 [thread overview]
Message-ID: <864j9e7s5n.fsf@gnu.org> (raw)
In-Reply-To: <86jzitz1l0.fsf@gnu.org> (message from Eli Zaretskii on Thu, 13 Jun 2024 11:30:51 +0300)
> Cc: 71499@debbugs.gnu.org, stefankangas@gmail.com, bkhl@elektrubadur.se
> Date: Thu, 13 Jun 2024 11:30:51 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> Meanwhile, Björn, I have a few comments to the patch:
>
> . it needs a NEWS entry announcing the new feature
> . is there any reason your code to handle the missing newline is not
> identical to what the implementation of require-final-newline
> does?
Ping! Björn, can you please post an updated patch with the above nits
taken care of? We can install this now on the master branch.
next prev parent reply other threads:[~2024-06-27 7:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 18:16 bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Björn Lindström
2024-06-12 5:21 ` Björn Lindström
2024-06-12 7:46 ` Eli Zaretskii
2024-06-12 9:04 ` Björn Lindström
2024-06-12 9:41 ` Eli Zaretskii
2024-06-12 12:38 ` Stefan Kangas
2024-06-13 7:38 ` Andrea Corallo
2024-06-13 8:30 ` Eli Zaretskii
2024-06-14 12:23 ` Robert Pluim
2024-06-14 12:50 ` Eli Zaretskii
2024-06-20 7:55 ` Stefan Kangas
2024-06-20 8:22 ` Robert Pluim
2024-06-20 8:55 ` Stefan Kangas
2024-06-20 9:45 ` Robert Pluim
2024-06-20 11:23 ` Stefan Kangas
2024-06-27 7:37 ` Eli Zaretskii [this message]
2024-06-29 11:59 ` Björn Lindström
2024-06-29 13:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864j9e7s5n.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71499@debbugs.gnu.org \
--cc=acorallo@gnu.org \
--cc=bkhl@elektrubadur.se \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).