From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72341: VC: CVS template lines not stripped when committing Date: Fri, 02 Aug 2024 10:19:30 +0300 Message-ID: <864j83wfwd.fsf@gnu.org> References: <20240728123256.GW9440@irregular-apocalypse.k.bsd.de> <86plqxz9t0.fsf@gnu.org> <20240728192115.GY9440@irregular-apocalypse.k.bsd.de> <86le1lylud.fsf@gnu.org> <20240729095312.GZ9440@irregular-apocalypse.k.bsd.de> <86a5i0z89z.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4577"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bad@bsd.de, 72341@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 02 09:21:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sZmb0-00014R-8r for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Aug 2024 09:21:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZmam-0005KG-8n; Fri, 02 Aug 2024 03:20:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZmaj-0005K0-9l for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 03:20:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sZmai-00012V-3e for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 03:20:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=RvaUcEhPF1m9NgmKo3unlPliACAPt7Bw7pBPQkEFsG8=; b=GLd857odn+MR8j+WLT33Cx5fZWvOJ0jStGXUSNsNKzs86ormMukRRcEPLy5rpj2kQpZeUUl6KaLgHNthn9jpEQbGU9JqcATNBFR8s+no5FXyIBNHwDZnmQVVNm26A+ceddPHckz8XGk6gjgSG5n9+knzJPuU8A/U5tLdCzRVkoO3LH1JWgTy3n64WpQ4tqz7uALLbgFd9TiyY4pyo3zqIRz9fxw+YJa4kAR6KnKmfq2C1dPgJJbZB86V+sA2oqxkciY5LTnpfvTGWp7hOtvQUKenSuo2o8jeAGLiaHgO6JhftcTcdDBDoimu+7wO2zyO58mDkXPnLXRdoIJJrqfrAw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sZmb0-0007GS-0V for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 03:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Aug 2024 07:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72341 X-GNU-PR-Package: emacs Original-Received: via spool by 72341-submit@debbugs.gnu.org id=B72341.172258321427853 (code B ref 72341); Fri, 02 Aug 2024 07:21:01 +0000 Original-Received: (at 72341) by debbugs.gnu.org; 2 Aug 2024 07:20:14 +0000 Original-Received: from localhost ([127.0.0.1]:52228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZmaD-0007FB-S9 for submit@debbugs.gnu.org; Fri, 02 Aug 2024 03:20:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZmaC-0007Eu-19 for 72341@debbugs.gnu.org; Fri, 02 Aug 2024 03:20:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZmZm-0000fa-Ti; Fri, 02 Aug 2024 03:19:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RvaUcEhPF1m9NgmKo3unlPliACAPt7Bw7pBPQkEFsG8=; b=mIQx1+zpFrF+ /DIwBMuXrXG5taSD/53ZtNEi4cQ3Zu8+DllDQHXrv7Z+MgudhqndIzTt3TPLZdaatxZPCYVkpol9f f5DGXf233YxjbSsv3/K1J9nt59CNWRKMy7pApmLUG+4+p8TqK38N3p5+apSPjNoYlG1xaznFl+gQR VxIU5XcLJ1dAxLw/PN+SndRjXunDVFFusPVghtO/0tKRZ+LgW4aaCs03KrxtEhK9BiN0MA2hhqMGW 6aTxEnzVknZ5cd2JKwN/uafZBxbeV6ohD6FQo7h8FfoDfMxLDmWDC3sxZArVtDYF49c4RZkSrQt5I Dwk3ogl4YPY5toyuXWr2Fw==; In-Reply-To: (message from Dmitry Gutov on Tue, 30 Jul 2024 16:35:29 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289629 Archived-At: > Date: Tue, 30 Jul 2024 16:35:29 +0300 > Cc: 72341@debbugs.gnu.org > From: Dmitry Gutov > > On 29/07/2024 15:34, Eli Zaretskii wrote: > > I'm unsure how to proceed with this. My bother is that this is a > > definite change in behavior wrt what VC did until now. Users of VC > > might be unaware of this removal, and could start some log lines with > > the prefix, which will mysteriously disappear from the log message. > > > > Dmitry, WDYT? Maybe we should add this removal guarded by a user > > option, by default off? Or maybe we can identify where the template > > starts and ends, and only remove in that region? > > If we do this, we'd only remove the lines starting with "CVS:". We could > also add special syntax highlighting for them. That would probably be > enough. Agreed. > Then vc-cvs-checkin would additionally process the commit message string > returned by log-edit-extract-headers. > > Note that it seems we only handle "templates" for CVS and RCS, so there > is no prior art for implementing this feature. Right. Patches welcome to implement this.