From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74606: 31.0.50; Another rsvg API change Date: Sun, 01 Dec 2024 16:55:01 +0200 Message-ID: <864j3n5u7u.fsf@gnu.org> References: <877c8m9el0.fsf@ledu-giraud.fr> <86zflh6kw0.fsf@gnu.org> <87plmbsg6x.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18271"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74606-done@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 01 15:56:38 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tHlNG-0004ZJ-8Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Dec 2024 15:56:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tHlMx-0007tZ-LP; Sun, 01 Dec 2024 09:56:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHlMi-0007s0-QN for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2024 09:56:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tHlMg-0000vv-8e for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2024 09:56:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=EY6i+m3ZbGJN9JJESj5aD9tvqZhOqYx5473vcv6Isik=; b=YpmoxjuTyTwi6wP/ka+DoK3XTrlI6HWup92Mvz+mhpnlcaMxBt3fdjQFgy+Sz7Urh3+NOAFNkudk+MUlWhJgEIsBfEJbd+hDjE5CbVWm72H33bYfC51nJNgwlZW7zMytLjQt4Jj8jB+dJScD7auXUmj2PifKnUqI4260hBYt2GXEB7u0zeA6umKmM9xzwHCo0pry7kV7FO/9HKa/lwBlLh+o41Qu9bp9QYTTtdRaFoj56LPdDM1689pqVztlJpkJpu4DJ1IBCia8N3UySzAe2e0MrM17gDS8Mf/6RNGz4MPrApAOVpsoS8jqvVOnZKiHwhMjVrBSdV7w2tm8I5//tw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tHlMg-00063R-3y for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2024 09:56:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Dec 2024 14:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 74606 X-GNU-PR-Package: emacs Mail-Followup-To: 74606@debbugs.gnu.org, eliz@gnu.org, manuel@ledu-giraud.fr Original-Received: via spool by 74606-done@debbugs.gnu.org id=D74606.173306491421341 (code D ref 74606); Sun, 01 Dec 2024 14:56:01 +0000 Original-Received: (at 74606-done) by debbugs.gnu.org; 1 Dec 2024 14:55:14 +0000 Original-Received: from localhost ([127.0.0.1]:50902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHlLu-0005Xx-AY for submit@debbugs.gnu.org; Sun, 01 Dec 2024 09:55:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHlLr-0005UM-IO for 74606-done@debbugs.gnu.org; Sun, 01 Dec 2024 09:55:12 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHlLm-0000mM-72; Sun, 01 Dec 2024 09:55:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EY6i+m3ZbGJN9JJESj5aD9tvqZhOqYx5473vcv6Isik=; b=LqfJGGHR5gO9 WYuluwrrf0ZSJ2De4mx5rW7mgQbuFmGTg1Q9+2lDOcL2592uY3GKiBa0nlhijBLRLfJyNaB1P6cNb k+NwYunJaaHrZtt1S6yYTsqYvQ3xF1Sc/ysUCaML0l+hmtnwFYICFfl7B85i4xKoe0bsJhkOyVdj6 Cc6UHLvK54qZTlN/Dqa2z7SSNXWxVTk4WnioFL+PCV19J1kCEHoeNMx34YOlc4Yk1r1BV1mPntBf6 sLEVk9ersdtEHGqgwS04uMUH2J/S94PocwULXTeEOO0+dwgMjBxon9UW4rc+NvsGCvIScRoRe6jah tO87f5lWqlf2Wu3I94Y4QA==; In-Reply-To: <87plmbsg6x.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sun, 01 Dec 2024 14:09:26 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296254 Archived-At: > From: Manuel Giraud > Cc: 74606@debbugs.gnu.org > Date: Sun, 01 Dec 2024 14:09:26 +0100 > > Eli Zaretskii writes: > > >> Date: Fri, 29 Nov 2024 17:42:19 +0100 > >> From: Manuel Giraud via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> This is not a bug (yet) per se but here is a new warning I get from > >> compiling Emacs with librsvg version 2.59.2: > >> > >> CC image.o > >> image.c: In function 'svg_load_image': > >> image.c:12360:3: warning: 'rsvg_handle_get_pixbuf' is deprecated: Use 'rsvg_handle_get_pixbuf_and_error' instead [-Wdeprecated-declarations] > >> 12360 | pixbuf = rsvg_handle_get_pixbuf (rsvg_handle); > >> | ^~~~~~ > >> In file included from /usr/local/include/librsvg-2.0/librsvg/rsvg.h:1332, > >> from image.c:11652: > >> /usr/local/include/librsvg-2.0/librsvg/rsvg-pixbuf.h:55:12: note: declared here > >> 55 | GdkPixbuf *rsvg_handle_get_pixbuf (RsvgHandle *handle); > >> | ^~~~~~~~~~~~~~~~~~~~~~ > > > > The way to fix this is to add code conditioned on librsvg version that > > uses rsvg_handle_get_pixbuf_and_error when available. > > Ok. According to this: > https://gitlab.gnome.org/GNOME/librsvg/-/blob/main/include/librsvg/rsvg-pixbuf.h?ref_type=heads#L52 > > this API is deprecated since 2.58 so here is the patch for this change. Thanks, installed on the emacs-30 branch, and closing the bug.