From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 74606-done@debbugs.gnu.org
Subject: bug#74606: 31.0.50; Another rsvg API change
Date: Sun, 01 Dec 2024 16:55:01 +0200 [thread overview]
Message-ID: <864j3n5u7u.fsf@gnu.org> (raw)
In-Reply-To: <87plmbsg6x.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sun, 01 Dec 2024 14:09:26 +0100)
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 74606@debbugs.gnu.org
> Date: Sun, 01 Dec 2024 14:09:26 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> Date: Fri, 29 Nov 2024 17:42:19 +0100
> >> From: Manuel Giraud via "Bug reports for GNU Emacs,
> >> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >>
> >> This is not a bug (yet) per se but here is a new warning I get from
> >> compiling Emacs with librsvg version 2.59.2:
> >>
> >> CC image.o
> >> image.c: In function 'svg_load_image':
> >> image.c:12360:3: warning: 'rsvg_handle_get_pixbuf' is deprecated: Use 'rsvg_handle_get_pixbuf_and_error' instead [-Wdeprecated-declarations]
> >> 12360 | pixbuf = rsvg_handle_get_pixbuf (rsvg_handle);
> >> | ^~~~~~
> >> In file included from /usr/local/include/librsvg-2.0/librsvg/rsvg.h:1332,
> >> from image.c:11652:
> >> /usr/local/include/librsvg-2.0/librsvg/rsvg-pixbuf.h:55:12: note: declared here
> >> 55 | GdkPixbuf *rsvg_handle_get_pixbuf (RsvgHandle *handle);
> >> | ^~~~~~~~~~~~~~~~~~~~~~
> >
> > The way to fix this is to add code conditioned on librsvg version that
> > uses rsvg_handle_get_pixbuf_and_error when available.
>
> Ok. According to this:
> https://gitlab.gnome.org/GNOME/librsvg/-/blob/main/include/librsvg/rsvg-pixbuf.h?ref_type=heads#L52
>
> this API is deprecated since 2.58 so here is the patch for this change.
Thanks, installed on the emacs-30 branch, and closing the bug.
next prev parent reply other threads:[~2024-12-01 14:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 16:42 bug#74606: 31.0.50; Another rsvg API change Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-30 11:06 ` Eli Zaretskii
2024-12-01 13:09 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-01 14:55 ` Eli Zaretskii [this message]
2024-12-02 11:58 ` Osama Rebach
2024-12-02 13:45 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-02 14:06 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-02 14:14 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-02 14:41 ` Eli Zaretskii
2024-12-02 15:02 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-02 15:11 ` Eli Zaretskii
2024-12-02 16:03 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-02 16:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864j3n5u7u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=74606-done@debbugs.gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).