From: Eli Zaretskii <eliz@gnu.org>
To: Lin Sun <sunlin7@hotmail.com>
Cc: 74881@debbugs.gnu.org
Subject: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs
Date: Fri, 27 Dec 2024 10:10:37 +0200 [thread overview]
Message-ID: <864j2py29u.fsf@gnu.org> (raw)
In-Reply-To: <TYCPR01MB1000467AA1CA86254006B3EEAFB0E2@TYCPR01MB10004.jpnprd01.prod.outlook.com> (message from Lin Sun on Fri, 27 Dec 2024 05:38:57 +0000)
> From: Lin Sun <sunlin7@hotmail.com>
> CC: "74881@debbugs.gnu.org" <74881@debbugs.gnu.org>
> Date: Fri, 27 Dec 2024 05:38:57 +0000
>
> Hi Eli,
>
> I checked the "ediff-delete-temp-files", it should be safe for executing. Is it more safe to wrap it with `ignore-errors` ? Like:
>
> +(defun ediff--delete-temp-files-on-kill-emacs ()
> + "Delete the temp-files associated with the ediff buffers."
> + (dolist (b (buffer-list))
> + (with-current-buffer b
> + (when (eq major-mode 'ediff-mode)
> + (ignore-errors (ediff-delete-temp-files))))))
>
Yes, probably. For a good measure, I'd also bind inhibit-interaction
to a non-nil value, to make sure we never ever ask the user anything
inside ediff-delete-temp-files.
next prev parent reply other threads:[~2024-12-27 8:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-15 5:59 bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Lin Sun
2024-12-15 8:04 ` Eli Zaretskii
2024-12-15 17:25 ` Lin Sun
2024-12-27 5:38 ` Lin Sun
2024-12-27 8:10 ` Eli Zaretskii [this message]
2024-12-27 17:34 ` Lin Sun
2024-12-28 7:38 ` Eli Zaretskii
2024-12-28 8:04 ` Lin Sun
2024-12-28 12:41 ` Eli Zaretskii
2024-12-28 17:40 ` Lin Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864j2py29u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=74881@debbugs.gnu.org \
--cc=sunlin7@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).