From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.bugs Subject: bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot Date: Thu, 24 Nov 2022 13:25:53 -0800 Message-ID: <8635a8jb8e.fsf@stephe-leake.org> References: <87educqkar.fsf@dfreeman.email> <86cz9jmg9r.fsf@stephe-leake.org> <87k03qvmla.fsf@dfreeman.email> <86fseckwvb.fsf@stephe-leake.org> <87tu2pohub.fsf@dfreeman.email> <86ilj5k0sn.fsf@stephe-leake.org> <87wn7l316m.fsf@dfreeman.email> <86edtsk3xi.fsf@stephe-leake.org> <87o7swv3nx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18935"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59149@debbugs.gnu.org, danny@dfreeman.email To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 22:28:49 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyJm2-0004iS-Na for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 22:28:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyJkQ-00065v-Gu; Thu, 24 Nov 2022 16:27:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyJkO-000659-4l for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 16:27:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyJkM-0003bh-QN for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 16:27:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyJkM-0008DP-Ly for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 16:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 21:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59149 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: 59149@debbugs.gnu.org, bug-gnu-emacs@gnu.org, Danny Freeman Original-Received: via spool by 59149-submit@debbugs.gnu.org id=B59149.166932517931500 (code B ref 59149); Thu, 24 Nov 2022 21:27:02 +0000 Original-Received: (at 59149) by debbugs.gnu.org; 24 Nov 2022 21:26:19 +0000 Original-Received: from localhost ([127.0.0.1]:60425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyJje-0008C0-QD for submit@debbugs.gnu.org; Thu, 24 Nov 2022 16:26:19 -0500 Original-Received: from outbound-ss-820.bluehost.com ([69.89.24.241]:38686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyJjd-0008Bn-F5 for 59149@debbugs.gnu.org; Thu, 24 Nov 2022 16:26:18 -0500 Original-Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id BC52A1004853B for <59149@debbugs.gnu.org>; Thu, 24 Nov 2022 21:25:57 +0000 (UTC) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with ESMTP id yJjIo3XCLMa19yJjIo34Bi; Thu, 24 Nov 2022 21:25:57 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=bKPTnNyZ c=1 sm=1 tr=0 ts=637fe165 a=dWLzHQi6WpdymmZIwiVdBw==:117 a=Fln8i1WyhtedwaIJAdHvmw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=vvvmwbhNdt4A:10:endurance_base64_authed_username_1 a=pGLkceISAAAA:8 a=9i_RQKNPAAAA:8 a=AsM5nZkiPfba1MwH8ecA:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=hqnlY9SSy_kA:10:uccc_2email_address a=6nYNOB5prDIA:10:uccc_2email_address a=hTmfk0G8CIYA:10:hookup_email_user_1 a=6dtDWsVvRhGLEA8dw3uH:22 a=Ev4oQ7kfJBNsvnoXShoW:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mdKS1/AfT9FyzZfZh2dC/97WSu2O0rN4ZlQuzW7/S80=; b=KWARqbUx6u/NBAUUwhOtoJrroe d40bmc5q9La/8GA082c8xZWuEZwpXRkvjNcwUyM8lDFwszMgXJfGxqgTbcTQwWnPnLQR/+r/gkHF9 mR6mZNZq1LTL9c2r4FqDypH0YIyP5EUnji5IkYd5juvirDXKaIKn0muj56EaGPhrFgbjdWu5wlYFO htEIVyBzy/Llc9lqcuYJjWWpPsEWiDk4K/WqrmRdM4gAyjHftlMVgwGG08jEP1OQbcCJQcTtoCH9i NBxu+9zo6tvsVe3jG0qIoJ99tFjBR5sTHYJ37/OX/n48d+oN06Z1bB/go1zq7+SAKeS0CiWVB2BG8 kXOaAKNQ==; Original-Received: from 135-180-197-170.fiber.dynamic.sonic.net ([135.180.197.170]:63437 helo=DESKTOP-G20DCG1) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oyJjI-0014DH-Dm; Thu, 24 Nov 2022 14:25:56 -0700 In-Reply-To: <87o7swv3nx.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Thu, 24 Nov 2022 14:16:18 +0000") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 135.180.197.170 X-Source-L: No X-Exim-ID: 1oyJjI-0014DH-Dm X-Source-Sender: 135-180-197-170.fiber.dynamic.sonic.net (DESKTOP-G20DCG1) [135.180.197.170]:63437 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 3 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248922 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Stephen Leake writes: > >> Jo=C3=A3o T=C3=A1vora writes: >> > 1. Get rid of the :apply-edit progress reporter entirely. To be honest, > I don't think it's doing much. We could just as well have a call to > message there, or nothing at all. It might be worth keeping a "debug message" there, gated by a new variable eglot--debug (boolean or integer). So we can turn on messages when we need to debug something. Or just keep it commented out; it's easy enough to run eval-defun after uncommenting. > 2. Do my original "sketchy" suggestion, where :$progress is considered a > built-in ignorable capability (and checked with eglot--server-capable > in the new code that Danny is proposing). Stephen's eglot-connect > trick is an acceptable technique. > > 3. Add a boolean user varible eglot-report-progress. I don't like to > add user variables unless they represent things directly related to > the fundamental LSP logic, and not its customization or evolution. > Since this seems to be of those fundamental things, I think it's > acceptable. > > The alternatives are: > > a: 1+2 > b: 1+3 > c: 2 > d: 3 > > Stephen, you request to shoosh that particular apply-edits progress > reporter is another separate request, we shouldn't let it block Danny's > effort to support $progress messages.=20=20 > So I think we should do either 'c' or 'd' for now, and we can always > address your request later. Ok. Since that rules out b, I vote for d. =20 --=20 -- Stephe