From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#60660: Support git-formatted patches in diff-mode Date: Mon, 09 Jan 2023 09:54:54 +0200 Organization: LINKOV.NET Message-ID: <86358k6t2p.fsf@mail.linkov.net> References: <86mt6ssx98.fsf@mail.linkov.net> <83h6x0q2qd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14109"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 60660@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 09 08:57:42 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEn2M-0003X7-0G for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Jan 2023 08:57:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEn1v-0005OK-3p; Mon, 09 Jan 2023 02:57:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEn1j-0005NP-SQ for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2023 02:57:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEn1i-0007B7-RK for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2023 02:57:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEn1i-0004RQ-NQ for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2023 02:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Jan 2023 07:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60660 X-GNU-PR-Package: emacs Original-Received: via spool by 60660-submit@debbugs.gnu.org id=B60660.167325097417008 (code B ref 60660); Mon, 09 Jan 2023 07:57:02 +0000 Original-Received: (at 60660) by debbugs.gnu.org; 9 Jan 2023 07:56:14 +0000 Original-Received: from localhost ([127.0.0.1]:35684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEn0v-0004QG-Mk for submit@debbugs.gnu.org; Mon, 09 Jan 2023 02:56:13 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:40539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEn0s-0004Po-SJ for 60660@debbugs.gnu.org; Mon, 09 Jan 2023 02:56:11 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id A8040FF803; Mon, 9 Jan 2023 07:56:02 +0000 (UTC) In-Reply-To: <83h6x0q2qd.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 08 Jan 2023 20:51:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252995 Archived-At: >> This patch for emacs-29 fixes this bug, and the rest of fontification >> could be implemented in master. > > OK for the emacs-29 branch Pushed to the emacs-29 branch. > (although I'm surprised that diff-beginning-of-hunk can return > a position that is not before point). Indeed, strange to see this in 'diff-beginning-of-hunk': (cond ... ((re-search-backward regexp nil t)) ; In the middle of a hunk. ((re-search-forward regexp nil t) ; At first hunk header. ======= Need to experiment more with this in master.